Changeset 37138 in webkit for trunk/JavaScriptCore/VM/CTI.cpp

Timestamp:

Sep 30, 2008, 11:16:18 PM (17 years ago)

Author:

[email protected]

Message:

Improve performance of CTI on windows.

Reviewed by Geoff Garen

Currently on platforms where the compiler doesn't allow us to safely
index relative to the address of a parameter we need to actually
provide a pointer to CTI runtime call arguments. This patch improves
performance in this case by making the CTI logic for restoring this
parameter much less conservative by only resetting it before we actually
make a call, rather than between each and every SF bytecode we generate
code for.

This results in a 3.6% on the v8 benchmark when compiled with MSVC.

File:

• trunk/JavaScriptCore/VM/CTI.cpp (modified) (10 diffs)

trunk/JavaScriptCore/VM/CTI.cpp

@@ -293 +293 @@
 ALWAYS_INLINE X86Assembler::JmpSrc CTI::emitCall(unsigned opcodeIndex, X86::RegisterID r)
 {
+    m_jit.emitRestoreArgumentReference();
     X86Assembler::JmpSrc call = m_jit.emitCall(r);
     m_calls.append(CallRecord(call, opcodeIndex));
@@ -305 +306 @@
     m_jit.movl_i32m(1, &inCalledCode);
 #endif
+    m_jit.emitRestoreArgumentReference();
     X86Assembler::JmpSrc call = m_jit.emitCall();
     m_calls.append(CallRecord(call, helper, opcodeIndex));
@@ -320 +322 @@
     m_jit.movl_i32m(1, &inCalledCode);
 #endif
+    m_jit.emitRestoreArgumentReference();
     X86Assembler::JmpSrc call = m_jit.emitCall();
     m_calls.append(CallRecord(call, helper, opcodeIndex));
@@ -335 +338 @@
     m_jit.movl_i32m(1, &inCalledCode);
 #endif
+    m_jit.emitRestoreArgumentReference();
     X86Assembler::JmpSrc call = m_jit.emitCall();
     m_calls.append(CallRecord(call, helper, opcodeIndex));
@@ -350 +354 @@
     m_jit.movl_i32m(1, &inCalledCode);
 #endif
+    m_jit.emitRestoreArgumentReference();
     X86Assembler::JmpSrc call = m_jit.emitCall();
     m_calls.append(CallRecord(call, helper, opcodeIndex));
@@ -365 +370 @@
     m_jit.movl_i32m(1, &inCalledCode);
 #endif
+    m_jit.emitRestoreArgumentReference();
     X86Assembler::JmpSrc call = m_jit.emitCall();
     m_calls.append(CallRecord(call, helper, opcodeIndex));
@@ -508 +514 @@
         emitGetPutArg(instruction[i + 2].u.operand, 0, X86::ecx);
         emitCall(i, Machine::cti_op_call_eval);
-        m_jit.emitRestoreArgumentReference();
 
         emitGetCTIParam(CTI_ARGS_r, X86::edi); // edi := r
@@ -850 +855 @@
 
         ASSERT_WITH_MESSAGE(m_machine->isOpcode(instruction[i].u.opcode), "privateCompileMainPass gone bad @ %d", i);
-        m_jit.emitRestoreArgumentReference();
         switch (m_machine->getOpcodeID(instruction[i].u.opcode)) {
         case op_mov: {
@@ -2022 +2026 @@
     for (Vector<SlowCaseEntry>::iterator iter = m_slowCases.begin(); iter != m_slowCases.end(); ++iter) {
         unsigned i = iter->to;
-        m_jit.emitRestoreArgumentReference();
         switch (m_machine->getOpcodeID(instruction[i].u.opcode)) {
         case op_add: {
@@ -2471 +2474 @@
         case op_construct: {
             m_jit.link(iter->from, m_jit.label());
-            m_jit.emitRestoreArgumentReference();
 
             // We jump to this slow case if the ctiCode for the codeBlock has not yet been generated; compile it now.