Changeset 37321 in webkit for trunk/JavaScriptCore/kjs/PropertyMap.cpp

Timestamp:

Oct 5, 2008, 5:58:42 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-05 Sam Weinig <​[email protected]>

Reviewed by Maciej Stachowiak.

Avoid an extra lookup when transitioning to an existing StructureID
by caching the offset of property that caused the transition.

1% win on V8 suite. Wash on SunSpider.

• kjs/PropertyMap.cpp: (JSC::PropertyMap::put):
• kjs/PropertyMap.h:
• kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::addPropertyTransition):
• kjs/StructureID.h: (JSC::StructureID::setCachedTransistionOffset): (JSC::StructureID::cachedTransistionOffset):

File:

• trunk/JavaScriptCore/kjs/PropertyMap.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/PropertyMap.cpp

@@ -115 +115 @@
 }
 
-void PropertyMap::put(const Identifier& propertyName, JSValue* value, unsigned attributes, bool checkReadOnly, JSObject* slotBase, PutPropertySlot& slot, PropertyStorage& propertyStorage)
+size_t PropertyMap::put(const Identifier& propertyName, JSValue* value, unsigned attributes, bool checkReadOnly, JSObject* slotBase, PutPropertySlot& slot, PropertyStorage& propertyStorage)
 {
     ASSERT(!propertyName.isNull());
@@ -145 +145 @@
         if (m_table->entries()[entryIndex - 1].key == rep) {
             if (checkReadOnly && (m_table->entries()[entryIndex - 1].attributes & ReadOnly))
-                return;
+                return WTF::notFound;
             // Put a new value in an existing hash table entry.
             propertyStorage[entryIndex - 2] = value;
             // Attributes are intentionally not updated.
             slot.setExistingProperty(slotBase, entryIndex - 2);
-            return;
+            return entryIndex - 2;
         } else if (entryIndex == deletedSentinelIndex) {
             // If we find a deleted-element sentinel, remember it for use later.
@@ -203 +203 @@
     checkConsistency(propertyStorage);
     slot.setNewProperty(slotBase, entryIndex - 2);
+    return entryIndex - 2;
 }