Changeset 37337 in webkit for trunk/JavaScriptCore/kjs/JSString.h

Timestamp:

Oct 6, 2008, 11:31:07 AM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-10-06 Maciej Stachowiak <​[email protected]>

Not reviewed. Build fix.

• revert toBoolean changes (r37333 and r37335); need to make WebCore work with these

• API/JSValueRef.cpp: (JSValueToBoolean):
• ChangeLog:
• JavaScriptCore.exp:
• VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
• VM/Machine.cpp: (JSC::Machine::privateExecute): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue):
• kjs/ArrayPrototype.cpp: (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncSome):
• kjs/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
• kjs/GetterSetter.h:
• kjs/JSCell.h: (JSC::JSValue::toBoolean):
• kjs/JSNumberCell.cpp: (JSC::JSNumberCell::toBoolean):
• kjs/JSNumberCell.h:
• kjs/JSObject.cpp: (JSC::JSObject::toBoolean):
• kjs/JSObject.h:
• kjs/JSString.cpp: (JSC::JSString::toBoolean):
• kjs/JSString.h:
• kjs/JSValue.h:
• kjs/RegExpConstructor.cpp: (JSC::setRegExpConstructorMultiline):
• kjs/RegExpObject.cpp: (JSC::RegExpObject::match):
• kjs/RegExpPrototype.cpp: (JSC::regExpProtoFuncToString):

JavaScriptGlue:

2008-10-06 Maciej Stachowiak <​[email protected]>

Not reviewed. Build fix.

• revert toBoolean changes (r37333 and r37335); need to make WebCore work with these

• JSUtils.cpp: (KJSValueToCFTypeInternal):

File:

• trunk/JavaScriptCore/kjs/JSString.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSString.h

@@ -93 +93 @@
         static PassRefPtr<StructureID> createStructureID(JSValue* proto) { return StructureID::create(proto, TypeInfo(StringType, NeedsThisConversion)); }
 
-        bool toBoolean() const { return !m_value.isEmpty(); }
-
     private:
         enum VPtrStealingHackType { VPtrStealingHack };
@@ -104 +102 @@
         virtual JSValue* toPrimitive(ExecState*, PreferredPrimitiveType) const;
         virtual bool getPrimitiveNumber(ExecState*, double& number, JSValue*& value);
+        virtual bool toBoolean(ExecState*) const;
         virtual double toNumber(ExecState*) const;
         virtual JSObject* toObject(ExecState*) const;