Changeset 37366 in webkit for trunk/JavaScriptCore/VM/CTI.cpp

Timestamp:

Oct 6, 2008, 8:53:47 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-06 Cameron Zwarich <​[email protected]>

Reviewed by Oliver Hunt.

Bug 21396: Remove the OptionalCalleeActivation call frame slot
<​https://bugs.webkit.org/show_bug.cgi?id=21396>

Remove the OptionalCalleeActivation call frame slot. We have to be
careful to store the activation object in a register, because objects
in the scope chain do not get marked.

This is a 0.3% speedup on both SunSpider and the V8 benchmark.

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
• VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::emitReturn):
• VM/CodeGenerator.h:
• VM/Machine.cpp: (JSC::Machine::dumpRegisters): (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_construct_JSConstruct):
• VM/Machine.h: (JSC::Machine::initializeCallFrame):
• VM/RegisterFile.h: (JSC::RegisterFile::):

File:

• trunk/JavaScriptCore/VM/CTI.cpp (modified) (3 diffs)

trunk/JavaScriptCore/VM/CTI.cpp

@@ -1172 +1172 @@
         }
         case op_tear_off_activation: {
+            emitGetPutArg(instruction[i + 1].u.operand, 0, X86::ecx);
             emitCall(i, Machine::cti_op_tear_off_activation);
-            i += 1;
+            i += 2;
             break;
         }
@@ -1942 +1943 @@
         }
         case op_enter_with_activation: {
-            emitCall(i, Machine::cti_op_push_activation);
-
             // Even though CTI doesn't use them, we initialize our constant
             // registers to zap stale pointers, to avoid unnecessarily prolonging
@@ -1951 +1950 @@
                 emitInitRegister(j);
 
-            i+= 1;
+            emitCall(i, Machine::cti_op_push_activation);
+            emitPutResult(instruction[i + 1].u.operand);
+
+            i+= 2;
             break;
         }