Changeset 37366 in webkit for trunk/JavaScriptCore/VM/Machine.h

Timestamp:

Oct 6, 2008, 8:53:47 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-06 Cameron Zwarich <​[email protected]>

Reviewed by Oliver Hunt.

Bug 21396: Remove the OptionalCalleeActivation call frame slot
<​https://bugs.webkit.org/show_bug.cgi?id=21396>

Remove the OptionalCalleeActivation call frame slot. We have to be
careful to store the activation object in a register, because objects
in the scope chain do not get marked.

This is a 0.3% speedup on both SunSpider and the V8 benchmark.

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
• VM/CodeBlock.cpp: (JSC::CodeBlock::dump):
• VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::emitReturn):
• VM/CodeGenerator.h:
• VM/Machine.cpp: (JSC::Machine::dumpRegisters): (JSC::Machine::unwindCallFrame): (JSC::Machine::privateExecute): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_construct_JSConstruct):
• VM/Machine.h: (JSC::Machine::initializeCallFrame):
• VM/RegisterFile.h: (JSC::RegisterFile::):

File:

• trunk/JavaScriptCore/VM/Machine.h (modified) (2 diffs)

trunk/JavaScriptCore/VM/Machine.h

@@ -236 +236 @@
         static void* SFX_CALL cti_vm_throw(CTI_ARGS);
         static void* SFX_CALL cti_vm_compile(CTI_ARGS);
-        static void SFX_CALL cti_op_push_activation(CTI_ARGS);
+        static JSValue* SFX_CALL cti_op_push_activation(CTI_ARGS);
         
 #endif // ENABLE(CTI)
@@ -325 +325 @@
         callFrame[RegisterFile::ArgumentCount] = argc; // original argument count (for the sake of the "arguments" object)
         callFrame[RegisterFile::Callee] = function;
-        callFrame[RegisterFile::OptionalCalleeActivation] = nullJSValue;
         callFrame[RegisterFile::OptionalCalleeArguments] = nullJSValue;
     }