Changeset 37498 in webkit for trunk/JavaScriptCore/kjs/MathObject.cpp

Timestamp:

Oct 10, 2008, 7:53:03 PM (17 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2008-10-10 Sam Weinig <​[email protected]>

Reviewed by Darin Adler.

• Add a workaround for a bug in ceil in Darwin libc.
• Remove old workarounds for JS math functions that are not needed anymore.

The math functions are heavily tested by fast/js/math.html.

• kjs/MathObject.cpp: (JSC::mathProtoFuncAbs): Remove workaround. (JSC::mathProtoFuncCeil): Ditto. (JSC::mathProtoFuncFloor): Ditto.
• wtf/MathExtras.h: (wtf_ceil): Add ceil workaround for darwin.

LayoutTests:

2008-10-10 Sam Weinig <​[email protected]>

Reviewed by Darin Adler.

• Update tests after fixing ceil(-0.1) behavior on darwin.

• fast/js/math-expected.txt:
• fast/js/resources/math.js: Remove code to detect sign of 0 now that the harness can handle it.
• fast/xpath/4XPath/Core/test_core_functions-expected.txt:
• fast/xpath/4XPath/Core/test_core_functions.html: Update test expect correct result of -0.

File:

• trunk/JavaScriptCore/kjs/MathObject.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/MathObject.cpp

@@ -115 +115 @@
 JSValue* mathProtoFuncAbs(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    double arg = args.at(exec, 0)->toNumber(exec);
-    return signbit(arg) ? jsNumber(exec, -arg) : jsNumber(exec, arg);
+    return jsNumber(exec, fabs(args.at(exec, 0)->toNumber(exec)));
 }
 
@@ -141 +140 @@
 JSValue* mathProtoFuncCeil(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    double arg = args.at(exec, 0)->toNumber(exec);
-    if (signbit(arg) && arg > -1.0)
-        return jsNumber(exec, -0.0);
-    return jsNumber(exec, ceil(arg));
+    return jsNumber(exec, ceil(args.at(exec, 0)->toNumber(exec)));
 }
 
@@ -159 +155 @@
 JSValue* mathProtoFuncFloor(ExecState* exec, JSObject*, JSValue*, const ArgList& args)
 {
-    double arg = args.at(exec, 0)->toNumber(exec);
-    if (signbit(arg) && arg == 0.0)
-        return jsNumber(exec, -0.0);
-    return jsNumber(exec, floor(arg));
+    return jsNumber(exec, floor(args.at(exec, 0)->toNumber(exec)));
 }