Changeset 37570 in webkit for trunk/JavaScriptCore/VM/CTI.cpp

Timestamp:

Oct 13, 2008, 5:20:49 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-13 Cameron Zwarich <​[email protected]>

Reviewed by Geoff Garen.

Bug 21541: Move RegisterFile growth check to callee
<​https://bugs.webkit.org/show_bug.cgi?id=21541>

Move the RegisterFile growth check to the callee in the common case,
where some of the information is known statically at JIT time. There is
still a check in the caller in the case where the caller provides too
few arguments.

This is a 2.1% speedup on the V8 benchmark, including a 5.1% speedup on
the Richards benchmark, a 4.1% speedup on the DeltaBlue benchmark, and a
1.4% speedup on the Earley-Boyer benchmark. It is also a 0.5% speedup on
SunSpider.

• VM/CTI.cpp: (JSC::CTI::privateCompile):
• VM/Machine.cpp: (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct):
• VM/Machine.h:
• VM/RegisterFile.h:
• masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::cmpl_mr): (JSC::X86Assembler::emitUnlinkedJg):

File:

• trunk/JavaScriptCore/VM/CTI.cpp (modified) (1 diff)

trunk/JavaScriptCore/VM/CTI.cpp

@@ -2616 +2616 @@
     emitPutToCallFrameHeader(X86::ecx, RegisterFile::ReturnPC);
 
+    X86Assembler::JmpSrc slowRegisterFileCheck;
+    X86Assembler::JmpDst afterRegisterFileCheck;
+    if (m_codeBlock->codeType == FunctionCode) {
+        emitGetCTIParam(CTI_ARGS_registerFile, X86::eax);
+        m_jit.leal_mr(m_codeBlock->numCalleeRegisters * sizeof(Register), X86::edi, X86::edx);
+        m_jit.cmpl_mr(OBJECT_OFFSET(RegisterFile, m_end), X86::eax, X86::edx);
+        slowRegisterFileCheck = m_jit.emitUnlinkedJg();
+        afterRegisterFileCheck = m_jit.label();
+    }
+
     privateCompileMainPass();
     privateCompileLinkPass();
     privateCompileSlowCases();
+
+    if (m_codeBlock->codeType == FunctionCode) {
+        m_jit.link(slowRegisterFileCheck, m_jit.label());
+        emitCall(0, Machine::cti_register_file_check);
+        X86Assembler::JmpSrc backToBody = m_jit.emitUnlinkedJmp();
+        m_jit.link(backToBody, afterRegisterFileCheck);
+    }
 
     ASSERT(m_jmpTable.isEmpty());