Changeset 37647 in webkit for trunk/JavaScriptCore/wtf/Platform.h

Timestamp:

Oct 16, 2008, 8:24:41 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-16 Maciej Stachowiak <​[email protected]>

Reviewed by Geoff Garen.

• fixed <rdar://problem/5806316> JavaScriptCore should not force building with gcc 4.0
• use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default

This time there is no performance regression; we can avoid having
to use the fastcall calling convention for CTI functions by using
varargs to prevent the compiler from moving things around on the
stack.

• Configurations/DebugRelease.xcconfig:
• JavaScriptCore.xcodeproj/project.pbxproj:
• VM/CTI.cpp:
• VM/Machine.h:
• wtf/Platform.h:

File:

• trunk/JavaScriptCore/wtf/Platform.h (modified) (1 diff)

trunk/JavaScriptCore/wtf/Platform.h

@@ -369 +369 @@
 #endif
 
-// Use "fastcall" calling convention on MSVC and GCC > 4.0
-#if COMPILER(MSVC) || (COMPILER(GCC) && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 0)))
+// Use "fastcall" calling convention on MSVC
+#if COMPILER(MSVC)
 #define WTF_USE_FAST_CALL_CTI_ARGUMENT 1
-#endif
-
-#if COMPILER(MSVC) || USE(FAST_CALL_CTI_ARGUMENT)
 #define WTF_USE_CTI_ARGUMENT 1
 #endif