Changeset 37653 in webkit for trunk/JavaScriptCore/kjs/JSObject.h

Timestamp:

Oct 17, 2008, 4:55:09 AM (17 years ago)

Author:

[email protected]

Message:

2008-10-17 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• speed up transitions that resize the property storage a fair bit

~3% speedup on v8 RayTrace benchmark, ~1% on DeltaBlue

• VM/CTI.cpp: (JSC::resizePropertyStorage): renamed from transitionObject, and reduced to just resize the object's property storage with one inline call. (JSC::CTI::privateCompilePutByIdTransition): Use a separate function for property storage resize, but still do all the rest of the work in assembly in that case, and pass the known compile-time constants of old and new size rather than structureIDs, saving a bunch of redundant memory access.
• kjs/JSObject.cpp: (JSC::JSObject::allocatePropertyStorage): Just call the inline version.
• kjs/JSObject.h: (JSC::JSObject::allocatePropertyStorageInline): Inline version of allocatePropertyStorage
• masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::pushl_i32): Add code to assmeble push of a constant; code originally by Cameron Zwarich.

File:

• trunk/JavaScriptCore/kjs/JSObject.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/JSObject.h

@@ -178 +178 @@
 
         void allocatePropertyStorage(size_t oldSize, size_t newSize);
+        void allocatePropertyStorageInline(size_t oldSize, size_t newSize);
         bool usingInlineStorage() const { return m_propertyStorage == m_inlineStorage; }
 
@@ -507 +508 @@
 }
 
+ALWAYS_INLINE void JSObject::allocatePropertyStorageInline(size_t oldSize, size_t newSize)
+{
+    ASSERT(newSize > oldSize);
+
+    JSValue** oldPropertStorage = m_propertyStorage;
+    m_propertyStorage = new JSValue*[newSize];
+
+    for (unsigned i = 0; i < oldSize; ++i)
+        m_propertyStorage[i] = oldPropertStorage[i];
+
+    if (oldPropertStorage != m_inlineStorage)
+        delete [] oldPropertStorage;
+}
+
 } // namespace JSC