Changeset 37653 in webkit for trunk/JavaScriptCore/masm/X86Assembler.h

Timestamp:

Oct 17, 2008, 4:55:09 AM (17 years ago)

Author:

[email protected]

Message:

2008-10-17 Maciej Stachowiak <​[email protected]>

Reviewed by Cameron Zwarich.

• speed up transitions that resize the property storage a fair bit

~3% speedup on v8 RayTrace benchmark, ~1% on DeltaBlue

• VM/CTI.cpp: (JSC::resizePropertyStorage): renamed from transitionObject, and reduced to just resize the object's property storage with one inline call. (JSC::CTI::privateCompilePutByIdTransition): Use a separate function for property storage resize, but still do all the rest of the work in assembly in that case, and pass the known compile-time constants of old and new size rather than structureIDs, saving a bunch of redundant memory access.
• kjs/JSObject.cpp: (JSC::JSObject::allocatePropertyStorage): Just call the inline version.
• kjs/JSObject.h: (JSC::JSObject::allocatePropertyStorageInline): Inline version of allocatePropertyStorage
• masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::pushl_i32): Add code to assmeble push of a constant; code originally by Cameron Zwarich.

File:

• trunk/JavaScriptCore/masm/X86Assembler.h (modified) (2 diffs)

trunk/JavaScriptCore/masm/X86Assembler.h

@@ -197 +197 @@
         PRE_OPERAND_SIZE                = 0x66,
         PRE_SSE_66                      = 0x66,
+        OP_PUSH_Iz                      = 0x68,
         OP_IMUL_GvEvIz                  = 0x69,
         OP_GROUP1_EvIz                  = 0x81,
@@ -293 +294 @@
         emitModRm_opm(GROUP5_OP_PUSH, base, offset);
     }
+
+    void pushl_i32(int imm)
+    {
+        m_buffer->putByte(OP_PUSH_Iz);
+        m_buffer->putInt(imm);
+    }
     
     void popl_r(RegisterID reg)