Changeset 37684 in webkit for trunk/JavaScriptCore/kjs/JSArray.h

Timestamp:

Oct 18, 2008, 6:52:42 PM (17 years ago)

Author:

Darin Adler

Message:

JavaScriptCore:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

• next step on ​https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
changing JSValuePtr to be a class, and then eventually renaming it
to JSValue once that's done.

• JavaScriptCore.exp: Update entry points, since some now take JSValue* instead of const JSValue*.

• API/APICast.h:
• API/JSCallbackConstructor.h:
• API/JSCallbackFunction.cpp:
• API/JSCallbackFunction.h:
• API/JSCallbackObject.h:
• API/JSCallbackObjectFunctions.h:
• API/JSContextRef.cpp:
• API/JSObjectRef.cpp:
• API/JSValueRef.cpp:
• VM/CTI.cpp:
• VM/CTI.h:
• VM/CodeBlock.cpp:
• VM/CodeBlock.h:
• VM/CodeGenerator.cpp:
• VM/CodeGenerator.h:
• VM/ExceptionHelpers.cpp:
• VM/ExceptionHelpers.h:
• VM/JSPropertyNameIterator.cpp:
• VM/JSPropertyNameIterator.h:
• VM/Machine.cpp:
• VM/Machine.h:
• VM/Register.h:
• kjs/ArgList.cpp:
• kjs/ArgList.h:
• kjs/Arguments.cpp:
• kjs/Arguments.h:
• kjs/ArrayConstructor.cpp:
• kjs/ArrayPrototype.cpp:
• kjs/BooleanConstructor.cpp:
• kjs/BooleanConstructor.h:
• kjs/BooleanObject.h:
• kjs/BooleanPrototype.cpp:
• kjs/CallData.cpp:
• kjs/CallData.h:
• kjs/ConstructData.cpp:
• kjs/ConstructData.h:
• kjs/DateConstructor.cpp:
• kjs/DateInstance.h:
• kjs/DatePrototype.cpp:
• kjs/DebuggerCallFrame.cpp:
• kjs/DebuggerCallFrame.h:
• kjs/ErrorConstructor.cpp:
• kjs/ErrorPrototype.cpp:
• kjs/ExecState.cpp:
• kjs/ExecState.h:
• kjs/FunctionConstructor.cpp:
• kjs/FunctionPrototype.cpp:
• kjs/GetterSetter.cpp:
• kjs/GetterSetter.h:
• kjs/InternalFunction.h:
• kjs/JSActivation.cpp:
• kjs/JSActivation.h:
• kjs/JSArray.cpp:
• kjs/JSArray.h:
• kjs/JSCell.cpp:
• kjs/JSCell.h:
• kjs/JSFunction.cpp:
• kjs/JSFunction.h:
• kjs/JSGlobalData.h:
• kjs/JSGlobalObject.cpp:
• kjs/JSGlobalObject.h:
• kjs/JSGlobalObjectFunctions.cpp:
• kjs/JSGlobalObjectFunctions.h:
• kjs/JSImmediate.cpp:
• kjs/JSImmediate.h:
• kjs/JSNotAnObject.cpp:
• kjs/JSNotAnObject.h:
• kjs/JSNumberCell.cpp:
• kjs/JSNumberCell.h:
• kjs/JSObject.cpp:
• kjs/JSObject.h:
• kjs/JSStaticScopeObject.cpp:
• kjs/JSStaticScopeObject.h:
• kjs/JSString.cpp:
• kjs/JSString.h:
• kjs/JSValue.h:
• kjs/JSVariableObject.h:
• kjs/JSWrapperObject.h:
• kjs/MathObject.cpp:
• kjs/NativeErrorConstructor.cpp:
• kjs/NumberConstructor.cpp:
• kjs/NumberConstructor.h:
• kjs/NumberObject.cpp:
• kjs/NumberObject.h:
• kjs/NumberPrototype.cpp:
• kjs/ObjectConstructor.cpp:
• kjs/ObjectPrototype.cpp:
• kjs/ObjectPrototype.h:
• kjs/PropertyMap.h:
• kjs/PropertySlot.cpp:
• kjs/PropertySlot.h:
• kjs/RegExpConstructor.cpp:
• kjs/RegExpConstructor.h:
• kjs/RegExpMatchesArray.h:
• kjs/RegExpObject.cpp:
• kjs/RegExpObject.h:
• kjs/RegExpPrototype.cpp:
• kjs/Shell.cpp:
• kjs/StringConstructor.cpp:
• kjs/StringObject.cpp:
• kjs/StringObject.h:
• kjs/StringObjectThatMasqueradesAsUndefined.h:
• kjs/StringPrototype.cpp:
• kjs/StructureID.cpp:
• kjs/StructureID.h:
• kjs/collector.cpp:
• kjs/collector.h:
• kjs/completion.h:
• kjs/grammar.y:
• kjs/interpreter.cpp:
• kjs/interpreter.h:
• kjs/lookup.cpp:
• kjs/lookup.h:
• kjs/nodes.h:
• kjs/operations.cpp:
• kjs/operations.h:
• kjs/protect.h:
• profiler/ProfileGenerator.cpp: Replace JSValue* with JSValuePtr.

JavaScriptGlue:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

• next step on ​https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
changing JSValuePtr to be a class, and then eventually renaming it
to JSValue once that's done.

• JSObject.cpp:
• JSValueWrapper.cpp:
• UserObjectImp.cpp:
• UserObjectImp.h: Replace JSValue* with JSValuePtr.

WebCore:

2008-10-18 Darin Adler <Darin Adler>

Reviewed by Cameron Zwarich.

• next step on ​https://bugs.webkit.org/show_bug.cgi?id=21732 improve performance by eliminating JSValue as a base class for JSCell

Use JSValuePtr everywhere instead of JSValue*. In the future, we'll be
changing JSValuePtr to be a class, and then eventually renaming it
to JSValue once that's done.

• bindings/js/JSAttrCustom.cpp:
• bindings/js/JSCSSRuleCustom.cpp:
• bindings/js/JSCSSStyleDeclarationCustom.cpp:
• bindings/js/JSCSSValueCustom.cpp:
• bindings/js/JSCanvasPixelArrayCustom.h:
• bindings/js/JSCanvasRenderingContext2DCustom.cpp:
• bindings/js/JSClipboardCustom.cpp:
• bindings/js/JSConsoleCustom.cpp:
• bindings/js/JSCustomSQLStatementCallback.cpp:
• bindings/js/JSCustomSQLStatementErrorCallback.cpp:
• bindings/js/JSCustomSQLTransactionCallback.cpp:
• bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
• bindings/js/JSCustomVoidCallback.cpp:
• bindings/js/JSCustomVoidCallback.h:
• bindings/js/JSCustomXPathNSResolver.cpp:
• bindings/js/JSDOMApplicationCacheCustom.cpp:
• bindings/js/JSDOMBinding.cpp:
• bindings/js/JSDOMBinding.h:
• bindings/js/JSDOMWindowBase.cpp:
• bindings/js/JSDOMWindowBase.h:
• bindings/js/JSDOMWindowCustom.cpp:
• bindings/js/JSDOMWindowCustom.h:
• bindings/js/JSDOMWindowShell.cpp:
• bindings/js/JSDOMWindowShell.h:
• bindings/js/JSDatabaseCustom.cpp:
• bindings/js/JSDocumentCustom.cpp:
• bindings/js/JSElementCustom.cpp:
• bindings/js/JSEventCustom.cpp:
• bindings/js/JSEventListener.cpp:
• bindings/js/JSEventTarget.cpp:
• bindings/js/JSEventTargetBase.h:
• bindings/js/JSEventTargetNodeCustom.cpp:
• bindings/js/JSHTMLAllCollection.h:
• bindings/js/JSHTMLAppletElementCustom.cpp:
• bindings/js/JSHTMLCollectionCustom.cpp:
• bindings/js/JSHTMLDocumentCustom.cpp:
• bindings/js/JSHTMLEmbedElementCustom.cpp:
• bindings/js/JSHTMLFormElementCustom.cpp:
• bindings/js/JSHTMLFrameElementCustom.cpp:
• bindings/js/JSHTMLFrameSetElementCustom.cpp:
• bindings/js/JSHTMLIFrameElementCustom.cpp:
• bindings/js/JSHTMLInputElementCustom.cpp:
• bindings/js/JSHTMLObjectElementCustom.cpp:
• bindings/js/JSHTMLOptionsCollectionCustom.cpp:
• bindings/js/JSHTMLSelectElementCustom.cpp:
• bindings/js/JSHTMLSelectElementCustom.h:
• bindings/js/JSHistoryCustom.cpp:
• bindings/js/JSImageDataCustom.cpp:
• bindings/js/JSInspectedObjectWrapper.cpp:
• bindings/js/JSInspectedObjectWrapper.h:
• bindings/js/JSInspectorCallbackWrapper.cpp:
• bindings/js/JSInspectorCallbackWrapper.h:
• bindings/js/JSJavaScriptCallFrameCustom.cpp:
• bindings/js/JSLocationCustom.cpp:
• bindings/js/JSMessagePortCustom.cpp:
• bindings/js/JSMimeTypeArrayCustom.cpp:
• bindings/js/JSNamedNodeMapCustom.cpp:
• bindings/js/JSNamedNodesCollection.cpp:
• bindings/js/JSNamedNodesCollection.h:
• bindings/js/JSNavigatorCustom.cpp:
• bindings/js/JSNodeCustom.cpp:
• bindings/js/JSNodeFilterCondition.cpp:
• bindings/js/JSNodeFilterCustom.cpp:
• bindings/js/JSNodeIteratorCustom.cpp:
• bindings/js/JSNodeListCustom.cpp:
• bindings/js/JSPluginArrayCustom.cpp:
• bindings/js/JSPluginCustom.cpp:
• bindings/js/JSPluginElementFunctions.cpp:
• bindings/js/JSPluginElementFunctions.h:
• bindings/js/JSQuarantinedObjectWrapper.cpp:
• bindings/js/JSQuarantinedObjectWrapper.h:
• bindings/js/JSRGBColor.cpp:
• bindings/js/JSRGBColor.h:
• bindings/js/JSSQLResultSetRowListCustom.cpp:
• bindings/js/JSSQLTransactionCustom.cpp:
• bindings/js/JSSVGElementInstanceCustom.cpp:
• bindings/js/JSSVGLengthCustom.cpp:
• bindings/js/JSSVGMatrixCustom.cpp:
• bindings/js/JSSVGPathSegCustom.cpp:
• bindings/js/JSSVGPathSegListCustom.cpp:
• bindings/js/JSSVGPointListCustom.cpp:
• bindings/js/JSSVGTransformListCustom.cpp:
• bindings/js/JSStorageCustom.cpp:
• bindings/js/JSStyleSheetCustom.cpp:
• bindings/js/JSStyleSheetListCustom.cpp:
• bindings/js/JSTextCustom.cpp:
• bindings/js/JSTreeWalkerCustom.cpp:
• bindings/js/JSXMLHttpRequestCustom.cpp:
• bindings/js/JSXMLHttpRequestUploadCustom.cpp:
• bindings/js/JSXSLTProcessorCustom.cpp:
• bindings/js/ScheduledAction.cpp:
• bindings/js/ScheduledAction.h:
• bindings/js/ScriptController.cpp:
• bindings/js/ScriptController.h:
• bindings/objc/WebScriptObject.mm:
• bindings/scripts/CodeGeneratorJS.pm:
• bridge/NP_jsobject.cpp:
• bridge/c/c_instance.cpp:
• bridge/c/c_instance.h:
• bridge/c/c_runtime.cpp:
• bridge/c/c_runtime.h:
• bridge/c/c_utility.cpp:
• bridge/jni/jni_instance.cpp:
• bridge/jni/jni_instance.h:
• bridge/jni/jni_jsobject.mm:
• bridge/jni/jni_objc.mm:
• bridge/jni/jni_runtime.cpp:
• bridge/jni/jni_runtime.h:
• bridge/jni/jni_utility.cpp:
• bridge/objc/objc_class.mm:
• bridge/objc/objc_instance.h:
• bridge/objc/objc_instance.mm:
• bridge/objc/objc_runtime.h:
• bridge/objc/objc_runtime.mm:
• bridge/objc/objc_utility.h:
• bridge/objc/objc_utility.mm:
• bridge/runtime.h:
• bridge/runtime_array.cpp:
• bridge/runtime_array.h:
• bridge/runtime_method.cpp:
• bridge/runtime_method.h:
• bridge/runtime_object.cpp:
• bridge/runtime_object.h:
• inspector/JavaScriptCallFrame.cpp:
• inspector/JavaScriptCallFrame.h:
• inspector/JavaScriptProfile.cpp:
• inspector/JavaScriptProfileNode.cpp:
• loader/FrameLoader.cpp:
• loader/FrameLoader.h:
• page/Console.cpp:
• page/Console.h:
• plugins/MimeTypeArray.h:
• plugins/Plugin.h:
• plugins/PluginArray.h:
• xml/XMLHttpRequest.cpp: Replace JSValue* with JSValuePtr.

File:

• trunk/JavaScriptCore/kjs/JSArray.h (modified) (8 diffs)

trunk/JavaScriptCore/kjs/JSArray.h

@@ -26 +26 @@
 namespace JSC {
 
-    typedef HashMap<unsigned, JSValue*> SparseArrayValueMap;
+    typedef HashMap<unsigned, JSValuePtr> SparseArrayValueMap;
 
     struct ArrayStorage {
@@ -34 +34 @@
         SparseArrayValueMap* m_sparseValueMap;
         void* lazyCreationData; // A JSArray subclass can use this to fill the vector lazily.
-        JSValue* m_vector[1];
+        JSValuePtr m_vector[1];
     };
 
@@ -48 +48 @@
         virtual bool getOwnPropertySlot(ExecState*, const Identifier& propertyName, PropertySlot&);
         virtual bool getOwnPropertySlot(ExecState*, unsigned propertyName, PropertySlot&);
-        virtual void put(ExecState*, unsigned propertyName, JSValue*); // FIXME: Make protected and add setItem.
+        virtual void put(ExecState*, unsigned propertyName, JSValuePtr); // FIXME: Make protected and add setItem.
 
         static const ClassInfo info;
@@ -56 +56 @@
 
         void sort(ExecState*);
-        void sort(ExecState*, JSValue* compareFunction, CallType, const CallData&);
+        void sort(ExecState*, JSValuePtr compareFunction, CallType, const CallData&);
 
-        void push(ExecState*, JSValue*);
-        JSValue* pop();
+        void push(ExecState*, JSValuePtr);
+        JSValuePtr pop();
 
         bool canGetIndex(unsigned i) { return i < m_fastAccessCutoff; }
-        JSValue* getIndex(unsigned i)
+        JSValuePtr getIndex(unsigned i)
         {
             ASSERT(canGetIndex(i));
@@ -69 +69 @@
 
         bool canSetIndex(unsigned i) { return i < m_fastAccessCutoff; }
-        JSValue* setIndex(unsigned i, JSValue* v)
+        JSValuePtr setIndex(unsigned i, JSValuePtr v)
         {
             ASSERT(canSetIndex(i));
@@ -78 +78 @@
 
     protected:
-        virtual void put(ExecState*, const Identifier& propertyName, JSValue*, PutPropertySlot&);
+        virtual void put(ExecState*, const Identifier& propertyName, JSValuePtr, PutPropertySlot&);
         virtual bool deleteProperty(ExecState*, const Identifier& propertyName);
         virtual bool deleteProperty(ExecState*, unsigned propertyName);
@@ -91 +91 @@
 
         bool getOwnPropertySlotSlowCase(ExecState*, unsigned propertyName, PropertySlot&);
-        void putSlowCase(ExecState*, unsigned propertyName, JSValue*);
+        void putSlowCase(ExecState*, unsigned propertyName, JSValuePtr);
 
         bool increaseVectorLength(unsigned newLength);
@@ -104 +104 @@
     };
 
-    JSArray* asArray(JSValue*);
+    JSArray* asArray(JSValuePtr);
 
     JSArray* constructEmptyArray(ExecState*);
     JSArray* constructEmptyArray(ExecState*, unsigned initialLength);
-    JSArray* constructArray(ExecState*, JSValue* singleItemValue);
+    JSArray* constructArray(ExecState*, JSValuePtr singleItemValue);
     JSArray* constructArray(ExecState*, const ArgList& values);
 
-    inline JSArray* asArray(JSValue* value)
+    inline JSArray* asArray(JSValuePtr value)
     {
         ASSERT(asObject(value)->inherits(&JSArray::info));