Changeset 37861 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 24, 2008, 2:07:39 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-24 Cameron Zwarich <​[email protected]>

Reviewed by Geoff Garen.

Remove ScopeChainNode::bottom() and inline it into its only caller,
ScopeChainnode::globalObject().

• kjs/JSGlobalObject.h: (JSC::ScopeChainNode::globalObject):
• kjs/ScopeChain.h: (JSC::ScopeChain::bottom):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/JSGlobalObject.h (modified) (1 diff)
• kjs/ScopeChain.h (modified) (3 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-24  Cameron Zwarich  <[email protected]>
+
+        Reviewed by Geoff Garen.
+
+        Remove ScopeChainNode::bottom() and inline it into its only caller,
+        ScopeChainnode::globalObject().
+
+        * kjs/JSGlobalObject.h:
+        (JSC::ScopeChainNode::globalObject):
+        * kjs/ScopeChain.h:
+        (JSC::ScopeChain::bottom):
+
 2008-10-24  Cameron Zwarich  <[email protected]>
 

trunk/JavaScriptCore/kjs/JSGlobalObject.h

@@ -330 +330 @@
     inline JSGlobalObject* ScopeChainNode::globalObject() const
     {
-        return asGlobalObject(bottom());
+        const ScopeChainNode* n = this;
+        while (n->next)
+            n = n->next;
+        return asGlobalObject(n->object);
     }
 

trunk/JavaScriptCore/kjs/ScopeChain.h

@@ -64 +64 @@
         }
 
-        JSObject* bottom() const;
-
         ScopeChainNode* push(JSObject*);
         ScopeChainNode* pop();
@@ -97 +95 @@
 
         return result;
-    }
-
-    inline JSObject* ScopeChainNode::bottom() const
-    {
-        const ScopeChainNode* n = this;
-        while (n->next)
-            n = n->next;
-        return n->object;
     }
 
@@ -189 +179 @@
 
         JSObject* top() const { return m_node->object; }
-        JSObject* bottom() const { return m_node->bottom(); }
 
         ScopeChainIterator begin() const { return m_node->begin(); }