Changeset 37868 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 24, 2008, 3:16:09 PM (17 years ago)

Author:

[email protected]

Message:

Suggested and rubber-stamped by Geoff Garen.

Fix a crash when opening Font Picker.

The change also hopefully fixes this bug, which I could never reproduce:
​https://bugs.webkit.org/show_bug.cgi?id=20241
<rdar://problem/6290576> Safari crashes at JSValueUnprotect() when fontpicker view close

• API/JSContextRef.cpp: (JSContextGetGlobalObject): Use lexical global object instead of dynamic one.

Location:

trunk/JavaScriptCore

Files:

• API/JSContextRef.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/JavaScriptCore/API/JSContextRef.cpp

@@ -121 +121 @@
 
     // It is necessary to call toThisObject to get the wrapper object when used with WebCore.
-    return toRef(exec->dynamicGlobalObject()->toThisObject(exec));
+    return toRef(exec->lexicalGlobalObject()->toThisObject(exec));
 }
 

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-24  Alexey Proskuryakov  <[email protected]>
+
+        Suggested and rubber-stamped by Geoff Garen.
+
+        Fix a crash when opening Font Picker.
+
+        The change also hopefully fixes this bug, which I could never reproduce:
+        https://bugs.webkit.org/show_bug.cgi?id=20241
+        <rdar://problem/6290576> Safari crashes at JSValueUnprotect() when fontpicker view close
+
+        * API/JSContextRef.cpp: (JSContextGetGlobalObject): Use lexical global object instead of
+        dynamic one.
+
 2008-10-24  Cameron Zwarich  <[email protected]>