Changeset 37876 in webkit for trunk/JavaScriptCore

Timestamp:

Oct 24, 2008, 5:09:56 PM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Darin Adler.

Get rid of a bonus ASSERT when using a null string as a regexp.
Specifically calling: RegularExpression::match() with String::empty()
will hit this ASSERT.
Chromium hits this, but I don't know of any way to make a layout test.

• pcre/pcre_exec.cpp: (jsRegExpExecute):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• pcre/pcre_exec.cpp (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-10-24  Eric Seidel  <[email protected]>
+
+        Reviewed by Darin Adler.
+        
+        Get rid of a bonus ASSERT when using a null string as a regexp.
+        Specifically calling: RegularExpression::match() with String::empty()
+        will hit this ASSERT.
+        Chromium hits this, but I don't know of any way to make a layout test.
+
+        * pcre/pcre_exec.cpp:
+        (jsRegExpExecute):
+
 2008-10-24  Alexey Proskuryakov  <[email protected]>
 

trunk/JavaScriptCore/pcre/pcre_exec.cpp

@@ -1956 +1956 @@
 {
     ASSERT(re);
-    ASSERT(subject);
+    ASSERT(subject || !length);
     ASSERT(offsetCount >= 0);
     ASSERT(offsets || offsetCount == 0);