Changeset 37901 in webkit for trunk/JavaScriptCore/VM/SamplingTool.cpp

Timestamp:

Oct 27, 2008, 1:37:08 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-27 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Added a mutex around the SamplingTool's ScopeNode* map, to solve a crash
when sampling the v8 tests.

• VM/SamplingTool.cpp: (JSC::SamplingTool::run): (JSC::SamplingTool::notifyOfScope):
• VM/SamplingTool.h: Since new ScopeNodes can be created after the SamplingTools has begun sampling, reads and writes to / from the map need to be synchronized. Shark says this doesn't measurably increase sampling overhead.

File:

• trunk/JavaScriptCore/VM/SamplingTool.cpp (modified) (2 diffs)

trunk/JavaScriptCore/VM/SamplingTool.cpp

@@ -103 +103 @@
 
 #if ENABLE(CODEBLOCK_SAMPLING)
+        MutexLocker locker(m_scopeSampleMapMutex);
         ScopeSampleRecord* record = m_scopeSampleMap->get(sample.codeBlock()->ownerNode);
         ASSERT(record);
@@ -118 +119 @@
 void SamplingTool::notifyOfScope(ScopeNode* scope)
 {
+    MutexLocker locker(m_scopeSampleMapMutex);
     m_scopeSampleMap->set(scope, new ScopeSampleRecord(scope));
 }