Changeset 37972 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Oct 29, 2008, 8:02:31 AM (17 years ago)

Author:

[email protected]

Message:

Emit the WillExecuteStatement debugger hook before the "else" body when there is no block for the "else" body. This allows breakpoints on those statements in the Web Inspector.

JavaScriptCore:

2008-10-28 Timothy Hatcher <​[email protected]>

Emit the WillExecuteStatement debugger hook before the "else" body
when there is no block for the "else" body. This allows breakpoints
on those statements in the Web Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=21944

Reviewed by Maciej Stachowiak.

• kjs/nodes.cpp: (JSC::IfElseNode::emitCode): Emit the WillExecuteStatement debugger hook before the else node if isn't a block.

WebCore:

2008-10-28 Timothy Hatcher <​[email protected]>

Add a manual test that checks breakpoints on a blockless body of
an "else" statement.

​https://bugs.webkit.org/show_bug.cgi?id=21944

Reviewed by Maciej Stachowiak.

• manual-tests/inspector/debugger-pause-on-else-statements.html: Added.

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -1159 +1159 @@
 
     generator.emitLabel(beforeElse.get());
+
+    if (!m_elseBlock->isBlock())
+        generator.emitDebugHook(WillExecuteStatement, m_elseBlock->firstLine(), m_elseBlock->lastLine());
+
     generator.emitNode(dst, m_elseBlock.get());