Changeset 38009 in webkit for trunk/JavaScriptCore/VM/CTI.cpp

Timestamp:

Oct 30, 2008, 2:16:46 PM (17 years ago)

Author:

[email protected]

Message:

2008-10-30 Cameron Zwarich <​[email protected]>

Reviewed by Sam Weinig.

Bug 21985: Opcodes should use eax as their destination register whenever possible
<​https://bugs.webkit.org/show_bug.cgi?id=21985>

Change more opcodes to use eax as the register for their final result,
and change calls to emitPutResult() that pass eax to rely on the default
value of eax.

• VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):

File:

• trunk/JavaScriptCore/VM/CTI.cpp (modified) (5 diffs)

trunk/JavaScriptCore/VM/CTI.cpp

@@ -1012 +1012 @@
             unsigned src = instruction[i + 2].u.operand;
             if (isConstant(src))
-                m_jit.movl_i32r(asInteger(getConstant(m_callFrame, src)), X86::edx);
+                m_jit.movl_i32r(asInteger(getConstant(m_callFrame, src)), X86::eax);
             else
-                emitGetArg(src, X86::edx);
-            emitPutResult(instruction[i + 1].u.operand, X86::edx);
+                emitGetArg(src, X86::eax);
+            emitPutResult(instruction[i + 1].u.operand);
             i += 3;
             break;
@@ -1072 +1072 @@
             m_jit.addl_i8r(getDeTaggedConstantImmediate(JSImmediate::oneImmediate()), X86::eax);
             m_slowCases.append(SlowCaseEntry(m_jit.emitUnlinkedJo(), i));
-            emitPutResult(srcDst, X86::eax);
+            emitPutResult(srcDst);
             i += 2;
             break;
@@ -1306 +1306 @@
             m_jit.movl_i32r(asInteger(globalObject), X86::eax);
             emitGetVariableObjectRegister(X86::eax, instruction[i + 3].u.operand, X86::eax);
-            emitPutResult(instruction[i + 1].u.operand, X86::eax);
+            emitPutResult(instruction[i + 1].u.operand);
             i += 4;
             break;
@@ -1408 +1408 @@
 
             m_jit.link(isImmediate, m_jit.label());
-            emitGetArg(instruction[i + 2].u.operand, X86::ecx);
-            emitPutResult(instruction[i + 1].u.operand, X86::ecx);
+            emitGetArg(instruction[i + 2].u.operand, X86::eax);
+            emitPutResult(instruction[i + 1].u.operand);
             m_jit.link(isObject, m_jit.label());
 
@@ -1604 +1604 @@
             m_jit.subl_i8r(getDeTaggedConstantImmediate(JSImmediate::oneImmediate()), X86::eax);
             m_slowCases.append(SlowCaseEntry(m_jit.emitUnlinkedJo(), i));
-            emitPutResult(srcDst, X86::eax);
+            emitPutResult(srcDst);
             i += 2;
             break;