Changeset 38101 in webkit for trunk/JavaScriptCore/wtf/ThreadingQt.cpp

Timestamp:

Nov 4, 2008, 10:57:01 AM (17 years ago)

Author:

Darin Adler

Message:

2008-11-03 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

• ​https://bugs.webkit.org/show_bug.cgi?id=22061 create script to check for exit-time destructors

• JavaScriptCore.exp: Changed to export functions rather than a global for the atomically initialized static mutex.

• JavaScriptCore.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.

• wtf/MainThread.cpp: (WTF::mainThreadFunctionQueueMutex): Changed to leak an object rather than using an exit time destructor. (WTF::functionQueue): Ditto.
• wtf/unicode/icu/CollatorICU.cpp: (WTF::cachedCollatorMutex): Ditto.

• wtf/Threading.h: Changed other platforms to share the Windows approach where the mutex is internal and the functions are exported.
• wtf/ThreadingGtk.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Ditto. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
• wtf/ThreadingNone.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Ditto. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
• wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): Changed to leak an object rather than using an exit time destructor. (WTF::lockAtomicallyInitializedStaticMutex): Mutex change. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto. (WTF::threadMap): Changed to leak an object rather than using an exit time destructor.
• wtf/ThreadingQt.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Mutex change. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
• wtf/ThreadingWin.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Added an assertion.

File:

• trunk/JavaScriptCore/wtf/ThreadingQt.cpp (modified) (3 diffs)

trunk/JavaScriptCore/wtf/ThreadingQt.cpp

@@ -65 +65 @@
 
 
-Mutex* atomicallyInitializedStaticMutex;
+static Mutex* atomicallyInitializedStaticMutex;
 
 static ThreadIdentifier mainThreadIdentifier;
@@ -123 +123 @@
 void initializeThreading()
 {
-    if(!atomicallyInitializedStaticMutex) {
+    if (!atomicallyInitializedStaticMutex) {
         atomicallyInitializedStaticMutex = new Mutex;
         threadMapMutex();
@@ -135 +135 @@
 }
 
+void lockAtomicallyInitializedStaticMutex()
+{
+    ASSERT(atomicallyInitializedStaticMutex);
+    atomicallyInitializedStaticMutex->lock();
+}
+
+void unlockAtomicallyInitializedStaticMutex()
+{
+    atomicallyInitializedStaticMutex->unlock();
+}
+
 ThreadIdentifier createThread(ThreadFunction entryPoint, void* data, const char*)
 {