Changeset 38311 in webkit for trunk/JavaScriptCore/VM/CodeBlock.h

Timestamp:

Nov 11, 2008, 12:06:11 PM (17 years ago)

Author:

[email protected]

Message:

2008-11-11 Cameron Zwarich <​[email protected]>

Rubber-stamped by Sam Weinig.

Bug 22179: Move EvalCodeCache from CodeBlock.h into its own file
<​https://bugs.webkit.org/show_bug.cgi?id=22179>

• GNUmakefile.am:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• VM/CodeBlock.h:
• VM/EvalCodeCache.h: Copied from VM/CodeBlock.h.
• VM/Machine.cpp:

File:

• trunk/JavaScriptCore/VM/CodeBlock.h (modified) (2 diffs)

trunk/JavaScriptCore/VM/CodeBlock.h

@@ -31 +31 @@
 #define CodeBlock_h
 
+#include "EvalCodeCache.h"
 #include "Instruction.h"
 #include "JSGlobalObject.h"
 #include "Nodes.h"
-#include "Parser.h"
 #include "RegExp.h"
-#include "SourceCode.h"
 #include "UString.h"
 #include <wtf/RefPtr.h>
@@ -212 +211 @@
     };
 
-    class EvalCodeCache {
-    public:
-        PassRefPtr<EvalNode> get(ExecState* exec, const UString& evalSource, ScopeChainNode* scopeChain, JSValue*& exceptionValue)
-        {
-            RefPtr<EvalNode> evalNode;
-
-            if (evalSource.size() < maxCacheableSourceLength && (*scopeChain->begin())->isVariableObject())
-                evalNode = cacheMap.get(evalSource.rep());
-
-            if (!evalNode) {
-                int errLine;
-                UString errMsg;
-                
-                SourceCode source = makeSource(evalSource);
-                evalNode = exec->globalData().parser->parse<EvalNode>(exec, exec->dynamicGlobalObject()->debugger(), source, &errLine, &errMsg);
-                if (evalNode) {
-                    if (evalSource.size() < maxCacheableSourceLength && (*scopeChain->begin())->isVariableObject() && cacheMap.size() < maxCacheEntries)
-                        cacheMap.set(evalSource.rep(), evalNode);
-                } else {
-                    exceptionValue = Error::create(exec, SyntaxError, errMsg, errLine, source.provider()->asID(), NULL);
-                    return 0;
-                }
-            }
-
-            return evalNode.release();
-        }
-
-    private:
-        static const int maxCacheableSourceLength = 256;
-        static const int maxCacheEntries = 64;
-
-        HashMap<RefPtr<UString::Rep>, RefPtr<EvalNode> > cacheMap;
-    };
-
     struct CodeBlock {
         CodeBlock(ScopeNode* ownerNode, CodeType codeType, PassRefPtr<SourceProvider> sourceProvider, unsigned sourceOffset)