Changeset 38349 in webkit for trunk/JavaScriptCore/parser/Nodes.h

Timestamp:

Nov 12, 2008, 4:48:23 PM (17 years ago)

Author:

[email protected]

Message:

2008-11-12 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=22192
+37 failures in fast/profiler

along with Darin's review comments in
​https://bugs.webkit.org/show_bug.cgi?id=22174
Simplified op_call by nixing its responsibility for moving the value of
"this" into the first argument slot

• VM/Machine.cpp: (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_arityCheck): (JSC::Machine::cti_vm_throw): Moved the throw logic into a function, since functions are better than macros.

• bytecompiler/CodeGenerator.cpp: (JSC::CodeGenerator::emitCall): (JSC::CodeGenerator::emitConstruct): Ensure that the function register is preserved if profiling is enabled, since the profiler uses that register.

• runtime/JSGlobalData.h: Renamed throwReturnAddress to exceptionLocation, because I had a hard time understanding what "throwReturnAddress" meant.

File:

• trunk/JavaScriptCore/parser/Nodes.h (modified) (1 diff)

trunk/JavaScriptCore/parser/Nodes.h

@@ -2079 +2079 @@
         int neededConstants()
         {
-            // We may need 1 more constant than the count given by the parser,
-            // because of the various uses of jsUndefined().
-            return m_numConstants + 1;
+            // We may need 2 more constants than the count given by the parser,
+            // because of the various uses of jsUndefined() and jsNull().
+            return m_numConstants + 2;
         }