Changeset 38641 in webkit for trunk/JavaScriptCore/assembler/X86Assembler.h

Timestamp:

Nov 20, 2008, 4:23:34 PM (17 years ago)

Author:

[email protected]

Message:

2008-11-20 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

A little more RegExp refactoring.

Created a helper function in the assembler for linking a vector of
JmpSrc to a location, and deployed it in a bunch of places.

• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/X86Assembler.h: (JSC::X86Assembler::link):
• wrec/WREC.cpp: (JSC::WREC::compileRegExp):
• wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateParentheses): (JSC::WREC::Generator::generateParenthesesResetTrampoline): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::terminateAlternative): (JSC::WREC::Generator::terminateDisjunction):
• wrec/WRECParser.cpp:
• wrec/WRECParser.h: (JSC::WREC::Parser::consumeHex):

File:

• trunk/JavaScriptCore/assembler/X86Assembler.h (modified) (3 diffs)

trunk/JavaScriptCore/assembler/X86Assembler.h

@@ -205 +205 @@
     };
 
+    typedef Vector<X86Assembler::JmpSrc> JmpSrcVector;
+    
     static const int maxInstructionSize = 16;
 
@@ -934 +936 @@
     }
     
+    void link(JmpSrcVector& vector, JmpDst to)
+    {
+        size_t size = vector.size();
+        for (size_t i = 0; i < size; ++i)
+            link(vector[i], to);
+        vector.clear();
+    }
+
     void link(JmpSrc from, JmpDst to)
     {
@@ -1157 +1167 @@
 };
 
-typedef Vector<X86Assembler::JmpSrc> JmpSrcVector;
+typedef X86Assembler::JmpSrcVector JmpSrcVector;
 
 } // namespace JSC