Changeset 38669 in webkit for trunk/JavaScriptCore/jit/JIT.cpp


Ignore:
Timestamp:
Nov 21, 2008, 11:31:34 AM (17 years ago)
Author:
[email protected]
Message:

2008-11-21 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.


A little more RegExp refactoring.


Moved all assembly from WREC.cpp into WRECGenerator helper functions.
This should help with portability and readability.


Removed ASSERTs after calls to executableCopy(), and changed
executableCopy() to ASSERT instead.

  • assembler/X86Assembler.h: (JSC::X86Assembler::executableCopy):
  • jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileGetByIdSelf): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain): (JSC::JIT::privateCompilePutByIdReplace): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::privateCompilePatchGetArrayLength):
  • wrec/WREC.cpp: (JSC::WREC::compileRegExp):
  • wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateReturnSuccess): (JSC::WREC::Generator::generateSaveIndex): (JSC::WREC::Generator::generateIncrementIndex): (JSC::WREC::Generator::generateLoopIfNotEndOfInput): (JSC::WREC::Generator::generateReturnFailure):
  • wrec/WRECGenerator.h:
  • wrec/WRECParser.h: (JSC::WREC::Parser::ignoreCase): (JSC::WREC::Parser::generator):
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/jit/JIT.cpp

    r38652 r38669  
    30603060
    30613061    void* code = __ executableCopy();
    3062     ASSERT(code);
    30633062
    30643063    // Translate vPC offsets into addresses in JIT generated code, for switch tables.
    … …  
    31323131
    31333132    void* code = __ executableCopy();
    3134     ASSERT(code);
    31353133
    31363134    X86Assembler::link(code, failureCases1, reinterpret_cast<void*>(Interpreter::cti_op_get_by_id_self_fail));
    … …  
    31753173
    31763174    void* code = __ executableCopy();
    3177     ASSERT(code);
    31783175
    31793176    // Use the repatch information to link the failure cases back to the original slow case routine.
    … …  
    32163213
    32173214    void* code = __ executableCopy();
    3218     ASSERT(code);
    32193215
    32203216#if USE(CTI_REPATCH_PIC)
    … …  
    32593255
    32603256    void* code = __ executableCopy();
    3261     ASSERT(code);
    32623257
    32633258    // Use the repatch information to link the failure cases back to the original slow case routine.
    … …  
    33133308
    33143309    void* code = __ executableCopy();
    3315     ASSERT(code);
    33163310
    33173311    for (unsigned i = 0; i < bucketsOfFail.size(); ++i)
    … …  
    33363330
    33373331    void* code = __ executableCopy();
    3338     ASSERT(code);
    33393332   
    33403333    X86Assembler::link(code, failureCases1, reinterpret_cast<void*>(Interpreter::cti_op_put_by_id_fail));
    … …  
    34323425
    34333426    void* code = __ executableCopy();
    3434     ASSERT(code);
    34353427
    34363428    if (failureCases.size())
    … …  
    36413633
    36423634    void* code = __ executableCopy();
    3643     ASSERT(code);
    36443635
    36453636    X86Assembler::link(code, array_failureCases1, reinterpret_cast<void*>(Interpreter::cti_op_get_by_id_array_fail));
    … …  
    37223713
    37233714    void* code = __ executableCopy();
    3724     ASSERT(code);
    37253715
    37263716    // Use the repatch information to link the failure cases back to the original slow case routine.
Note: See TracChangeset for help on using the changeset viewer.