Changeset 38673 in webkit for trunk/JavaScriptCore/runtime/Collector.cpp

Timestamp:

Nov 21, 2008, 1:20:41 PM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=22402
Replace abort() with CRASH()

• wtf/Assertions.h: Added a different method to crash, which should work even is 0xbbadbeef is a valid memory address.

• runtime/Collector.cpp:
• wtf/FastMalloc.cpp:
• wtf/FastMalloc.h:
• wtf/TCSpinLock.h: Replace abort() with CRASH().

File:

• trunk/JavaScriptCore/runtime/Collector.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/Collector.cpp

@@ -284 +284 @@
     ASSERT(heapType == PrimaryHeap || heap.extraCost == 0);
     // FIXME: If another global variable access here doesn't hurt performance
-    // too much, we could abort() in NDEBUG builds, which could help ensure we
+    // too much, we could CRASH() in NDEBUG builds, which could help ensure we
     // don't spend any time debugging cases where we allocate inside an object's
     // deallocation code.
@@ -975 +975 @@
     ASSERT((primaryHeap.operationInProgress == NoOperation) | (numberHeap.operationInProgress == NoOperation));
     if ((primaryHeap.operationInProgress != NoOperation) | (numberHeap.operationInProgress != NoOperation))
-        abort();
+        CRASH();
 
     JAVASCRIPTCORE_GC_BEGIN();