Changeset 38688 in webkit for trunk/JavaScriptCore/bytecode/CodeBlock.cpp

Timestamp:

Nov 21, 2008, 7:34:43 PM (17 years ago)

Author:

[email protected]

Message:

2008-11-21 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

Add (really) polymorphic caching for get by id self.
Very similar to caching of prototype accesses, described below.

Oh, also, probably shouldn't have been leaking those structure list objects.

4% preogression on deltablue.

• bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::derefStructures): (JSC::PrototypeStructureList::derefStructures):
• bytecode/Instruction.h:
• bytecode/Opcode.h:
• interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_get_by_id_self_fail):
• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::patchGetByIdSelf):
• jit/JIT.h: (JSC::JIT::compileGetByIdSelfList):

File:

• trunk/JavaScriptCore/bytecode/CodeBlock.cpp (modified) (2 diffs)

trunk/JavaScriptCore/bytecode/CodeBlock.cpp

@@ -643 +643 @@
             break;
         }
+        case op_get_by_id_self_list: {
+            printGetByIdOp(location, it, identifiers, "get_by_id_self_list");
+            break;
+        }
         case op_get_by_id_proto: {
             printGetByIdOp(location, it, identifiers, "get_by_id_proto");
@@ -1024 +1028 @@
         return;
     }
-    if (vPC[0].u.opcode == interpreter->getOpcode(op_get_by_id_proto_list)) {
-        PrototypeStructureList* prototypeStructures = vPC[4].u.prototypeStructure;
-        int count = vPC[5].u.operand;
-        for (int i = 0; i < count; ++i) {
-            PrototypeStructureList::ProtoStubInfo& info = prototypeStructures->list[i];
-            ASSERT(info.base);
-            ASSERT(info.proto);
-            ASSERT(info.stubRoutine);
-            info.base->deref();
-            info.proto->deref();
-            WTF::fastFreeExecutable(info.stubRoutine);
-        }
+    if ((vPC[0].u.opcode == interpreter->getOpcode(op_get_by_id_proto_list))
+        || (vPC[0].u.opcode == interpreter->getOpcode(op_get_by_id_self_list))) {
+        PolymorphicAccessStructureList* polymorphicStructures = vPC[4].u.polymorphicStructures;
+        polymorphicStructures->derefStructures(vPC[5].u.operand);
+        delete polymorphicStructures;
         return;
     }