Changeset 38745 in webkit for trunk/JavaScriptCore/wrec/WREC.cpp

Timestamp:

Nov 24, 2008, 10:10:17 PM (17 years ago)

Author:

[email protected]

Message:

2008-11-24 Geoffrey Garen <​[email protected]>

Reviewed by Sam Weinig.

Unroll the regexp matching loop by 1. 10% speedup on simple matching
stress test. No change on SunSpider.

(I decided not to unroll to arbitrary levels because the returns diminsh
quickly.)

• wrec/WREC.cpp: (JSC::WREC::compileRegExp):
• wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateJumpIfEndOfInput): (JSC::WREC::Generator::generateJumpIfNotEndOfInput):
• wrec/WRECGenerator.h:
• wrec/WRECParser.h: (JSC::WREC::Parser::error): (JSC::WREC::Parser::parsePattern):

File:

• trunk/JavaScriptCore/wrec/WREC.cpp (modified) (1 diff)

trunk/JavaScriptCore/wrec/WREC.cpp

@@ -60 +60 @@
 
     Generator::JmpDst beginPattern = __ label();
-    if (!parser.parsePattern(failures)) {
-        *error_ptr = "Regular expression malformed.";
-        return 0;
-    }
+    parser.parsePattern(failures);
     generator.generateReturnSuccess();
 
     __ link(failures, __ label());
     generator.generateIncrementIndex();
-    generator.generateLoopIfNotEndOfInput(beginPattern);
+    generator.generateJumpIfEndOfInput(failures);
+    parser.parsePattern(failures);
+    generator.generateReturnSuccess();
+
+    __ link(failures, __ label());
+    generator.generateIncrementIndex();
+    generator.generateJumpIfNotEndOfInput(beginPattern);
     generator.generateReturnFailure();
+
+    if (parser.error()) {
+        *error_ptr = "Regular expression malformed.";
+        return 0;
+    }
 
     *numSubpatterns_ptr = parser.numSubpatterns();