Changeset 38850 in webkit for trunk/WebCore/storage/DatabaseThread.cpp

Timestamp:

Nov 30, 2008, 12:31:11 AM (17 years ago)

Author:

[email protected]

Message:

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=22530
Assertion failures seen on buildbot due to uninitialized WorkerThread::m_threadID

• dom/WorkerThread.cpp: (WebCore::WorkerThread::start): Protect worker startup with a mutex to ensure that this function runs to completion before the thread begins execution. (WebCore::WorkerThread::workerThread): Updated comments. (WebCore::WorkerThread::stop): Ditto.
• dom/WorkerThread.h: Renamed m_workerContextMutex to m_threadCreationMutex, because it now protects startup as a whole.

• storage/DatabaseThread.cpp:
• storage/DatabaseThread.h:
• storage/LocalStorageThread.cpp:
• storage/LocalStorageThread.h: Fixed the same m_threadID problem.

File:

• trunk/WebCore/storage/DatabaseThread.cpp (modified) (2 diffs)

trunk/WebCore/storage/DatabaseThread.cpp

@@ -49 +49 @@
 bool DatabaseThread::start()
 {
+    MutexLocker lock(m_threadCreationMutex);
+
     if (m_threadID)
         return true;
@@ -76 +78 @@
 void* DatabaseThread::databaseThread()
 {
-    LOG(StorageAPI, "Starting DatabaseThread %p", this);
+    {
+        // Wait for DatabaseThread::start() to complete.
+        MutexLocker lock(m_threadCreationMutex);
+        LOG(StorageAPI, "Started DatabaseThread %p", this);
+    }
 
     AutodrainedPool pool;