Changeset 38917 in webkit for trunk/JavaScriptCore/parser/Nodes.cpp

Timestamp:

Dec 2, 2008, 1:52:24 PM (16 years ago)

Author:

[email protected]

Message:

2008-12-02 Geoffrey Garen <​[email protected]>

Reviewed by Geoffrey Garen. (Patch by Cameron Zwarich <​[email protected]>.)

Fixed ​https://bugs.webkit.org/show_bug.cgi?id=22482
REGRESSION (r37991): Occasionally see "Scene rendered incorrectly"
message when running the V8 Raytrace benchmark

Rolled out r37991. It didn't properly save xmm0, which is caller-save,
before calling helper functions.

SunSpider and v8 benchmarks show little change -- possibly a .2%
SunSpider regression, possibly a .2% v8 benchmark speedup.

• assembler/X86Assembler.h: (JSC::X86Assembler::):
• bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
• bytecode/Instruction.h: (JSC::Instruction::):
• bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitUnaryOp):
• bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitToJSNumber): (JSC::BytecodeGenerator::emitTypeOf): (JSC::BytecodeGenerator::emitGetPropertyNames):
• interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
• interpreter/Interpreter.h:
• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
• jit/JIT.h:
• parser/Nodes.cpp: (JSC::UnaryOpNode::emitBytecode): (JSC::BinaryOpNode::emitBytecode): (JSC::EqualNode::emitBytecode):
• parser/ResultType.h: (JSC::ResultType::isReusable): (JSC::ResultType::mightBeNumber):
• runtime/JSNumberCell.h:

File:

• trunk/JavaScriptCore/parser/Nodes.cpp (modified) (3 diffs)

trunk/JavaScriptCore/parser/Nodes.cpp

@@ -1094 +1094 @@
 {
     RegisterID* src = generator.emitNode(m_expr.get());
-    return generator.emitUnaryOp(opcodeID(), generator.finalDestination(dst), src, m_expr->resultDescriptor());
+    return generator.emitUnaryOp(opcodeID(), generator.finalDestination(dst), src);
 }
 
@@ -1116 +1116 @@
         if (m_expr1->isNull() || m_expr2->isNull()) {
             RefPtr<RegisterID> src = generator.emitNode(dst, m_expr1->isNull() ? m_expr2.get() : m_expr1.get());
-            return generator.emitUnaryOp(op_neq_null, generator.finalDestination(dst, src.get()), src.get(), ResultType::unknown());
+            return generator.emitUnaryOp(op_neq_null, generator.finalDestination(dst, src.get()), src.get());
         }
     }
@@ -1129 +1129 @@
     if (m_expr1->isNull() || m_expr2->isNull()) {
         RefPtr<RegisterID> src = generator.emitNode(dst, m_expr1->isNull() ? m_expr2.get() : m_expr1.get());
-        return generator.emitUnaryOp(op_eq_null, generator.finalDestination(dst, src.get()), src.get(), ResultType::unknown());
+        return generator.emitUnaryOp(op_eq_null, generator.finalDestination(dst, src.get()), src.get());
     }