Changeset 38975 in webkit for trunk/JavaScriptCore/assembler/AssemblerBuffer.h

Timestamp:

Dec 3, 2008, 4:10:53 PM (16 years ago)

Author:

[email protected]

Message:

2008-12-03 Sam Weinig <​[email protected]>

Reviewed by Geoffrey Garen.

Remove shared AssemblerBuffer 1MB buffer and instead give AssemblerBuffer
an 256 byte inline capacity.

1% progression on Sunspider.

• assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::~AssemblerBuffer): (JSC::AssemblerBuffer::grow):
• assembler/MacroAssembler.h: (JSC::MacroAssembler::MacroAssembler):
• assembler/X86Assembler.h: (JSC::X86Assembler::X86Assembler):
• interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter):
• interpreter/Interpreter.h:
• jit/JIT.cpp: (JSC::JIT::JIT):
• parser/Nodes.cpp: (JSC::RegExpNode::emitBytecode):
• runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create):
• runtime/RegExp.h:
• runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
• runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
• runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
• wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp):
• wrec/WRECGenerator.h: (JSC::WREC::Generator::Generator):
• wrec/WRECParser.h: (JSC::WREC::Parser::Parser):

File:

• trunk/JavaScriptCore/assembler/AssemblerBuffer.h (modified) (4 diffs)

trunk/JavaScriptCore/assembler/AssemblerBuffer.h

@@ -38 +38 @@
 
     class AssemblerBuffer {
+        static const int inlineCapacity = 256;
     public:
-        AssemblerBuffer(int capacity)
-            : m_buffer(static_cast<char*>(fastMalloc(capacity)))
-            , m_capacity(capacity)
+        AssemblerBuffer()
+            : m_buffer(m_inlineBuffer)
+            , m_capacity(inlineCapacity)
             , m_size(0)
         {
@@ -48 +49 @@
         ~AssemblerBuffer()
         {
-            fastFree(m_buffer);
+            if (m_buffer != m_inlineBuffer)
+                fastFree(m_buffer);
         }
 
@@ -113 +115 @@
         }
 
-        AssemblerBuffer* reset()
-        {
-            m_size = 0;
-            return this;
-        }
-
         void* executableCopy()
         {
@@ -136 +132 @@
         {
             m_capacity += m_capacity / 2;
-            m_buffer = static_cast<char*>(fastRealloc(m_buffer, m_capacity));
+
+            if (m_buffer == m_inlineBuffer) {
+                char* newBuffer = static_cast<char*>(fastMalloc(m_capacity));
+                m_buffer = static_cast<char*>(memcpy(newBuffer, m_buffer, m_size));
+            } else
+                m_buffer = static_cast<char*>(fastRealloc(m_buffer, m_capacity));
         }
 
+        char m_inlineBuffer[inlineCapacity];
         char* m_buffer;
         int m_capacity;