Changeset 39061 in webkit for trunk/JavaScriptCore/assembler/MacroAssembler.h

Timestamp:

Dec 5, 2008, 7:25:23 PM (16 years ago)

Author:

[email protected]

Message:

2008-12-05 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

Ordering of branch operands in MacroAssembler in unnecessarily inconsistent.

je, jg etc take an immediate operand as the second argument, but for the
equality branches (je, jne) the immediate operand was the first argument. This
was unnecessarily inconsistent. Change je, jne methods to take the immediate
as the second argument.

​https://bugs.webkit.org/show_bug.cgi?id=22703

• assembler/MacroAssembler.h: (JSC::MacroAssembler::je32): (JSC::MacroAssembler::jne32):
• jit/JIT.cpp: (JSC::JIT::compileOpStrictEq):
• wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacterPair): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionWordBoundary):

File:

• trunk/JavaScriptCore/assembler/MacroAssembler.h (modified) (4 diffs)

trunk/JavaScriptCore/assembler/MacroAssembler.h

@@ -579 +579 @@
     }
     
-    Jump je32(Imm32 imm, RegisterID reg)
+    Jump je32(RegisterID reg, Imm32 imm)
     {
         compareImm32ForBranchEquality(reg, imm.m_value);
@@ -651 +651 @@
     }
 
-    Jump jne32(Imm32 imm, RegisterID reg)
+    Jump jne32(RegisterID reg, Imm32 imm)
     {
         compareImm32ForBranchEquality(reg, imm.m_value);
@@ -703 +703 @@
     //     jne32(reg1, reg2).linkTo(topOfLoop);
 
-    void je32(Imm32 imm, RegisterID op2, Label target)
-    {
-        je32(imm, op2).linkTo(target, this);
+    void je32(RegisterID op1, Imm32 imm, Label target)
+    {
+        je32(op1, imm).linkTo(target, this);
     }
 
@@ -728 +728 @@
     }
 
-    void jne32(Imm32 imm, RegisterID op2, Label target)
-    {
-        jne32(imm, op2).linkTo(target, this);
+    void jne32(RegisterID op1, Imm32 imm, Label target)
+    {
+        jne32(op1, imm).linkTo(target, this);
     }