Changeset 39083 in webkit for trunk/JavaScriptCore/jit/JIT.cpp

Timestamp:

Dec 7, 2008, 3:55:04 PM (16 years ago)

Author:

[email protected]

Message:

<rdar://problem/6309878> Need more granular control over allocation of executable memory (21783)
<​https://bugs.webkit.org/show_bug.cgi?id=21783>

Reviewed by Cameron Zwarich and Sam Weinig

Add a new allocator for use by the JIT that provides executable pages, so
we can get rid of the current hack that makes the entire heap executable.

1-2% progression on SunSpider-v8, 1% on SunSpider. Reduces memory usage as well!

File:

• trunk/JavaScriptCore/jit/JIT.cpp (modified) (3 diffs)

trunk/JavaScriptCore/jit/JIT.cpp

@@ -1991 +1991 @@
     ASSERT(m_jmpTable.isEmpty());
 
-    void* code = __ executableCopy();
+    RefPtr<ExecutablePool> allocator = m_globalData->poolForSize(__ size());
+    m_codeBlock->setExecutablePool(allocator.get());
+    void* code = __ executableCopy(allocator.get());
 
     // Translate vPC offsets into addresses in JIT generated code, for switch tables.
@@ -2219 +2221 @@
 
     // All trampolines constructed! copy the code, link up calls, and set the pointers on the Machine object.
-
-    void* code = __ executableCopy();
+    m_interpreter->m_executablePool = m_globalData->poolForSize(__ size());
+    void* code = __ executableCopy(m_interpreter->m_executablePool.get());
 
     X86Assembler::link(code, array_failureCases1, reinterpret_cast<void*>(Interpreter::cti_op_get_by_id_array_fail));
@@ -2244 +2246 @@
 }
 
-void JIT::freeCTIMachineTrampolines(Interpreter* interpreter)
-{
-    WTF::fastFreeExecutable(interpreter->m_ctiArrayLengthTrampoline);
-}
-
 void JIT::emitGetVariableObjectRegister(RegisterID variableObject, int index, RegisterID dst)
 {