Changeset 39268 in webkit for trunk/JavaScriptCore/jit/JITArithmetic.cpp

Timestamp:

Dec 12, 2008, 9:25:22 PM (16 years ago)

Author:

[email protected]

Message:

2008-12-12 Gavin Barraclough <​[email protected]>

Reviewed by Camron Zwarich.

Replace emitPutCallArg methods with emitPutJITStubArg methods. Primarily to make the argument numbering
more sensible (1-based incrementing by 1, rather than 0-based incrementing by 4). The CTI name also seems
to be being deprecated from the code generally.

• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompileCTIMachineTrampolines):
• jit/JIT.h:
• jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase):
• jit/JITCall.cpp: (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallEvalSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCall):
• jit/JITInlineMethods.h: (JSC::JIT::emitPutJITStubArg): (JSC::JIT::emitPutJITStubArgConstant): (JSC::JIT::emitGetJITStubArg): (JSC::JIT::emitPutJITStubArgFromVirtualRegister):
• jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase):

File:

• trunk/JavaScriptCore/jit/JITArithmetic.cpp (modified) (2 diffs)

trunk/JavaScriptCore/jit/JITArithmetic.cpp

@@ -49 +49 @@
 void JIT::compileBinaryArithOp(OpcodeID opcodeID, unsigned dst, unsigned src1, unsigned src2, OperandTypes)
 {
-    emitPutCTIArgFromVirtualRegister(src1, 0, X86::ecx);
-    emitPutCTIArgFromVirtualRegister(src2, 4, X86::ecx);
+    emitPutJITStubArgFromVirtualRegister(src1, 1, X86::ecx);
+    emitPutJITStubArgFromVirtualRegister(src2, 2, X86::ecx);
     if (opcodeID == op_add)
         emitCTICall(Interpreter::cti_op_add);
@@ -324 +324 @@
         linkSlowCase(iter);
 
-    emitPutCTIArgFromVirtualRegister(src1, 0, X86::ecx);
-    emitPutCTIArgFromVirtualRegister(src2, 4, X86::ecx);
+    emitPutJITStubArgFromVirtualRegister(src1, 1, X86::ecx);
+    emitPutJITStubArgFromVirtualRegister(src2, 2, X86::ecx);
     if (opcodeID == op_add)
         emitCTICall(Interpreter::cti_op_add);