Changeset 39268 in webkit for trunk/JavaScriptCore/jit/JITPropertyAccess.cpp

Timestamp:

Dec 12, 2008, 9:25:22 PM (16 years ago)

Author:

[email protected]

Message:

2008-12-12 Gavin Barraclough <​[email protected]>

Reviewed by Camron Zwarich.

Replace emitPutCallArg methods with emitPutJITStubArg methods. Primarily to make the argument numbering
more sensible (1-based incrementing by 1, rather than 0-based incrementing by 4). The CTI name also seems
to be being deprecated from the code generally.

• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompileCTIMachineTrampolines):
• jit/JIT.h:
• jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase):
• jit/JITCall.cpp: (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallEvalSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCall):
• jit/JITInlineMethods.h: (JSC::JIT::emitPutJITStubArg): (JSC::JIT::emitPutJITStubArgConstant): (JSC::JIT::emitGetJITStubArg): (JSC::JIT::emitPutJITStubArgFromVirtualRegister):
• jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdSlowCase):

File:

• trunk/JavaScriptCore/jit/JITPropertyAccess.cpp (modified) (4 diffs)

trunk/JavaScriptCore/jit/JITPropertyAccess.cpp

@@ -56 +56 @@
     emitGetVirtualRegister(baseVReg, X86::eax);
 
-    emitPutCTIArg(X86::eax, 0);
-    emitPutCTIArgConstant(reinterpret_cast<unsigned>(ident), 4);
+    emitPutJITStubArg(X86::eax, 1);
+    emitPutJITStubArgConstant(reinterpret_cast<unsigned>(ident), 2);
     emitCTICall(Interpreter::cti_op_get_by_id_generic);
     emitPutVirtualRegister(resultVReg);
@@ -76 +76 @@
     emitGetVirtualRegisters(baseVReg, X86::eax, valueVReg, X86::edx);
 
-    emitPutCTIArgConstant(reinterpret_cast<unsigned>(ident), 4);
-    emitPutCTIArg(X86::eax, 0);
-    emitPutCTIArg(X86::edx, 8);
+    emitPutJITStubArgConstant(reinterpret_cast<unsigned>(ident), 2);
+    emitPutJITStubArg(X86::eax, 1);
+    emitPutJITStubArg(X86::edx, 3);
     emitCTICall(Interpreter::cti_op_put_by_id_generic);
 }
@@ -129 +129 @@
     JmpDst coldPathBegin = __ label();
 #endif
-    emitPutCTIArg(X86::eax, 0);
-    emitPutCTIArgConstant(reinterpret_cast<unsigned>(ident), 4);
+    emitPutJITStubArg(X86::eax, 1);
+    emitPutJITStubArgConstant(reinterpret_cast<unsigned>(ident), 2);
     JmpSrc call = emitCTICall(Interpreter::cti_op_get_by_id);
     ASSERT(X86Assembler::getDifferenceBetweenLabels(coldPathBegin, call) == repatchOffsetGetByIdSlowCaseCall);
@@ -169 +169 @@
     linkSlowCase(iter);
 
-    emitPutCTIArgConstant(reinterpret_cast<unsigned>(ident), 4);
-    emitPutCTIArg(X86::eax, 0);
-    emitPutCTIArg(X86::edx, 8);
+    emitPutJITStubArgConstant(reinterpret_cast<unsigned>(ident), 2);
+    emitPutJITStubArg(X86::eax, 1);
+    emitPutJITStubArg(X86::edx, 3);
     JmpSrc call = emitCTICall(Interpreter::cti_op_put_by_id);