Changeset 39297 in webkit for trunk/JavaScriptCore/interpreter/RegisterFile.h

Timestamp:

Dec 15, 2008, 4:03:41 AM (16 years ago)

Author:

[email protected]

Message:

Reviewed by Oliver Hunt.

<rdar://problem/6444455> Worker Thread crash running multiple workers for a moderate amount of time

WebCore:

• dom/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Detach the thread. Without this, one page of its stack was never unmmaped, and fragmentation made RegisterFile allocaiton fail after a while.

JavaScriptCore:

• interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): Improve error handling: if mmap fails, crash immediately, and print out the reason.

File:

• trunk/JavaScriptCore/interpreter/RegisterFile.h (modified) (2 diffs)

trunk/JavaScriptCore/interpreter/RegisterFile.h

@@ -33 +33 @@
 #include "Collector.h"
 #if HAVE(MMAP)
+#include <errno.h>
 #include <sys/mman.h>
 #endif
@@ -122 +123 @@
 #if HAVE(MMAP)
             m_buffer = static_cast<Register*>(mmap(0, bufferLength, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANON, -1, 0));
-            ASSERT(reinterpret_cast<intptr_t>(m_buffer) != -1);
+            if (m_buffer == MAP_FAILED) {
+                fprintf(stderr, "Could not allocate register file: %d\n", errno);
+                CRASH();
+            }
 #elif HAVE(VIRTUALALLOC)
             // FIXME: Use VirtualAlloc, and commit pages as we go.