Changeset 39337 in webkit for trunk/JavaScriptCore/runtime/MathObject.cpp

Timestamp:

Dec 16, 2008, 1:15:22 PM (16 years ago)

Author:

Nikolas Zimmermann

Message:

Reviewed by Darin Adler.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=22876

Unify random number generation in JavaScriptCore & WebCore, by introducing
wtf/RandomNumber.h and moving wtf_random/wtf_random_init out of MathExtras.h.

wtf_random_init() has been renamed to initializeRandomNumberGenerator() and
lives in it's own private header: wtf/RandomNumberSeed.h, only intended to
be used from within JavaScriptCore.

wtf_random() has been renamed to randomNumber() and lives in a public header
wtf/RandomNumber.h, usable from within JavaScriptCore & WebCore. It encapsulates
the code taking care of initializing the random number generator (only when
building without ENABLE(JSC_MULTIPLE_THREADS), otherwhise initializeThreading()
already took care of that).

Functional change on darwin: Use random() instead of rand(), as it got a larger
period (more randomness). HTMLFormElement already contains this implementation
and I just moved it in randomNumber(), as special case for PLATFORM(DARWIN).

File:

• trunk/JavaScriptCore/runtime/MathObject.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/MathObject.cpp

@@ -27 +27 @@
 #include <wtf/Assertions.h>
 #include <wtf/MathExtras.h>
+#include <wtf/RandomNumber.h>
 
 namespace JSC {
@@ -211 +212 @@
 JSValue* mathProtoFuncRandom(ExecState* exec, JSObject*, JSValue*, const ArgList&)
 {
-#if !ENABLE(JSC_MULTIPLE_THREADS)
-    static bool didInitRandom;
-    if (!didInitRandom) {
-        wtf_random_init();
-        didInitRandom = true;
-    }
-#endif
-
-    return jsNumber(exec, wtf_random());
+    return jsNumber(exec, randomNumber());
 }