Changeset 39600 in webkit for trunk/JavaScriptCore/runtime/Collector.cpp

Timestamp:

Jan 5, 2009, 9:21:13 AM (16 years ago)

Author:

[email protected]

Message:

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23115
Create a version of ASSERT for use with otherwise unused variables

JavaScriptCore:

• wtf/Assertions.h: Added ASSERT_UNUSED.

• jit/ExecutableAllocatorPosix.cpp: (JSC::ExecutablePool::systemRelease):
• runtime/Collector.cpp: (JSC::Heap::destroy): (JSC::Heap::heapAllocate):
• runtime/JSNotAnObject.cpp: (JSC::JSNotAnObject::toPrimitive): (JSC::JSNotAnObject::getPrimitiveNumber): (JSC::JSNotAnObject::toBoolean): (JSC::JSNotAnObject::toNumber): (JSC::JSNotAnObject::toString): (JSC::JSNotAnObject::getOwnPropertySlot): (JSC::JSNotAnObject::put): (JSC::JSNotAnObject::deleteProperty): (JSC::JSNotAnObject::getPropertyNames):
• wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): Use it in some places that used other idioms for this purpose.

WebCore:

• loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::verifySchemaVersion): Use the new ASSERT_UNUSED macro.

File:

• trunk/JavaScriptCore/runtime/Collector.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/Collector.cpp

@@ -162 +162 @@
 #if ENABLE(JSC_MULTIPLE_THREADS)
     if (m_currentThreadRegistrar) {
-#ifndef NDEBUG
-        int error =
-#endif
-            pthread_key_delete(m_currentThreadRegistrar);
-        ASSERT(!error);
+        int error = pthread_key_delete(m_currentThreadRegistrar);
+        ASSERT_UNUSED(error, !error);
     }
 
@@ -278 +275 @@
     ASSERT(JSLock::lockCount() > 0);
     ASSERT(JSLock::currentThreadIsHoldingLock());
-    ASSERT(s <= HeapConstants<heapType>::cellSize);
-    UNUSED_PARAM(s); // s is now only used for the above assert
+    ASSERT_UNUSED(s, s <= HeapConstants<heapType>::cellSize);
 
     ASSERT(heap.operationInProgress == NoOperation);