Changeset 39672 in webkit for trunk/JavaScriptCore/wtf/ThreadSpecific.h

Timestamp:

Jan 6, 2009, 11:24:18 PM (16 years ago)

Author:

[email protected]

Message:

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=23142
ThreadGlobalData leaks seen on buildbot

• wtf/ThreadSpecific.h: (WTF::ThreadSpecific::destroy): Temporarily reset the thread specific value to make getter work on Mac OS X.

• wtf/Platform.h: Touch this file again to make sure all Windows builds use the most recent version of ThreadSpecific.h.

File:

• trunk/JavaScriptCore/wtf/ThreadSpecific.h (modified) (1 diff)

trunk/JavaScriptCore/wtf/ThreadSpecific.h

@@ -98 +98 @@
 {
     Data* data = static_cast<Data*>(ptr);
+
+    // We want get() to keep working while data destructor works, because it can be called indirectly by the destructor.
+    // Some pthreads implementations zero out the pointer before calling destroy(), so we temporarily reset it.
+    pthread_setspecific(data->owner->m_key, ptr);
     data->value->~T();
     fastFree(data->value);
-    // Only reset the pointer after value destructor finishes - otherwise, code in destructor could trigger
-    // re-creation of the object.
     pthread_setspecific(data->owner->m_key, 0);
     delete data;