Changeset 39984 in webkit for trunk/JavaScriptCore/pcre/pcre_compile.cpp

Timestamp:

Jan 16, 2009, 1:51:38 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2009-01-16 Geoffrey Garen <​[email protected]>

Reviewed by Darin Adler.

Fixed <rdar://problem/6452301> REGRESSION: Latest WebKit nightlies
turn "c" into "" when stripping
c_ character

• wrec/WRECParser.cpp: (JSC::WREC::Parser::consumeEscape): Mimic a Firefox quirk when parsing control escapes inside character classes.

LayoutTests:

2009-01-16 Geoffrey Garen <​[email protected]>

Reviewed by Darin Adler.

Added tests for <rdar://problem/6452301> REGRESSION: Latest WebKit
nightlies turn "c" into "" when stripping
c_ character

• fast/regex/malformed-escapes-expected.txt:
• fast/regex/resources/malformed-escapes.js:

File:

• trunk/JavaScriptCore/pcre/pcre_compile.cpp (modified) (1 diff)

trunk/JavaScriptCore/pcre/pcre_compile.cpp

@@ -304 +304 @@
                 
                 c = *ptr;
-                if (!isASCIIAlpha(c)) {
+
+                /* To match Firefox, inside a character class, we also accept
+                   numbers and '_' as control characters */
+                if ((!isClass && !isASCIIAlpha(c)) || (!isASCIIAlphanumeric(c) && c != '_')) {
                     c = '\\';
                     ptr -= 2;