Changeset 40133 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Jan 22, 2009, 1:51:47 PM (16 years ago)

Author:

Beth Dakin

Message:

JavaScriptCore:

2009-01-22 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
fast/js/numeric-conversion.html is broken, and corresponding
<rdar://problem/6514842>

The basic problem here is that parseInt(Infinity) should be NaN,
but we were returning 0. NaN matches Safari 3.2.1 and Firefox.

• runtime/JSGlobalObjectFunctions.cpp: (JSC::globalFuncParseInt):

LayoutTests:

2009-01-22 Beth Dakin <Beth Dakin>

Reviewed by Sam Weinig.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
fast/js/numeric-conversion.html is broken, and corresponding
<rdar://problem/6514842>

The basic problem here is that parseInt(Infinity) should be NaN,
but we were returning 0. NaN matches Safari 3.2.1 and Firefox.

• fast/js/numeric-conversion-expected.txt:
• fast/js/resources/numeric-conversion.js:

File:

• trunk/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp

@@ -305 +305 @@
         if (isfinite(d))
             return jsNumber(exec, floor(d));
-        if (isnan(d))
+        if (isnan(d) || isinf(d))
             return jsNaN(&exec->globalData());
         return js0();