Changeset 40169 in webkit for trunk/JavaScriptCore/runtime

Timestamp:

Jan 23, 2009, 11:40:56 AM (16 years ago)

Author:

[email protected]

Message:

2009-01-23 Anders Carlsson <​[email protected]>

Reviewed by Sam Weinig.

Turn on -Wmissing-prototypes and fix the warnings.

• API/JSClassRef.cpp: (clearReferenceToPrototype):
• Configurations/Base.xcconfig:
• runtime/Collector.cpp: (JSC::getPlatformThreadRegisters):
• runtime/ExceptionHelpers.cpp: (JSC::createError):
• runtime/JSGlobalObjectFunctions.h:
• runtime/JSNumberCell.h:
• runtime/UString.cpp: (JSC::initializeStaticBaseString): (JSC::createRep):
• wtf/FastMalloc.cpp:
• wtf/Threading.cpp:

Location:

trunk/JavaScriptCore/runtime

Files:

• Collector.cpp (modified) (1 diff)
• ExceptionHelpers.cpp (modified) (4 diffs)
• JSGlobalObjectFunctions.h (modified) (1 diff)
• JSNumberCell.h (modified) (2 diffs)
• UString.cpp (modified) (2 diffs)

trunk/JavaScriptCore/runtime/Collector.cpp

@@ -667 +667 @@
 #endif
 
-size_t getPlatformThreadRegisters(const PlatformThread& platformThread, PlatformThreadRegisters& regs)
+static size_t getPlatformThreadRegisters(const PlatformThread& platformThread, PlatformThreadRegisters& regs)
 {
 #if PLATFORM(DARWIN)

trunk/JavaScriptCore/runtime/ExceptionHelpers.cpp

@@ -32 +32 @@
 #include "CodeBlock.h"
 #include "CallFrame.h"
+#include "JSGlobalObjectFunctions.h"
 #include "JSObject.h"
 #include "JSNotAnObject.h"
@@ -38 +39 @@
 
 namespace JSC {
-
-static void substitute(UString& string, const UString& substring)
-{
-    int position = string.find("%s");
-    ASSERT(position != -1);
-    UString newString = string.substr(0, position);
-    newString.append(substring);
-    newString.append(string.substr(position + 2));
-    string = newString;
-}
 
 class InterruptedExecutionError : public JSObject {
@@ -64 +55 @@
 }
 
-JSValuePtr createError(ExecState* exec, ErrorType e, const char* msg)
+static JSValuePtr createError(ExecState* exec, ErrorType e, const char* msg)
 {
     return Error::create(exec, e, msg, -1, -1, 0);
-}
-
-JSValuePtr createError(ExecState* exec, ErrorType e, const char* msg, const Identifier& label)
-{
-    UString message = msg;
-    substitute(message, label.ustring());
-    return Error::create(exec, e, message, -1, -1, 0);
-}
-
-JSValuePtr createError(ExecState* exec, ErrorType e, const char* msg, JSValuePtr v)
-{
-    UString message = msg;
-    substitute(message, v.toString(exec));
-    return Error::create(exec, e, message, -1, -1, 0);
 }
 
@@ -103 +80 @@
 }
     
-bool isStrWhiteSpace(UChar c);
-
 static UString createErrorMessage(ExecState* exec, CodeBlock* codeBlock, int, int expressionStart, int expressionStop, JSValuePtr value, UString error)
 {

trunk/JavaScriptCore/runtime/JSGlobalObjectFunctions.h

@@ -53 +53 @@
     static const double mantissaOverflowLowerBound = 9007199254740992.0;
     double parseIntOverflow(const char*, int length, int radix);
+    bool isStrWhiteSpace(UChar);
 
 } // namespace JSC

trunk/JavaScriptCore/runtime/JSNumberCell.h

@@ -47 +47 @@
     struct Instruction;
 
+    JSValuePtr jsNumberCell(ExecState*, double);
+
     class JSNumberCell : public JSCell {
         friend class JIT;
@@ -106 +108 @@
 
     JSValuePtr jsNumberCell(JSGlobalData*, double);
-    JSValuePtr jsNumberCell(ExecState*, double);
 
     inline bool isNumberCell(JSValuePtr v)

trunk/JavaScriptCore/runtime/UString.cpp

@@ -192 +192 @@
 UString* UString::nullUString;
 
-void initializeStaticBaseString(int len, UChar* buf, UString::BaseString& base)
+static void initializeStaticBaseString(int len, UChar* buf, UString::BaseString& base)
 {
     base.offset = 0;
@@ -497 +497 @@
 }
 
-PassRefPtr<UString::Rep> createRep(const char* c)
+static PassRefPtr<UString::Rep> createRep(const char* c)
 {
     if (!c)