Changeset 40279 in webkit for trunk/JavaScriptCore/jit/JIT.cpp

Timestamp:

Jan 26, 2009, 5:08:53 PM (16 years ago)

Author:

[email protected]

Message:

2009-01-26 Gavin Barraclough <​[email protected]>

Reviewed by Darin Adler.

Fixes for eq null & neq null, on 64-bit JIT.
​https://bugs.webkit.org/show_bug.cgi?id=23559

This patch degrades 64-bit JIT performance on some benchmarks,
due to the whole not-being-incorrect thing.

• jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):

File:

• trunk/JavaScriptCore/jit/JIT.cpp (modified) (4 diffs)

trunk/JavaScriptCore/jit/JIT.cpp

@@ -792 +792 @@
             // Now handle the immediate cases - undefined & null
             isImmediate.link(this);
-            and32(Imm32(~JSImmediate::ExtendedTagBitUndefined), X86::eax);
+            andPtr(Imm32(~JSImmediate::ExtendedTagBitUndefined), X86::eax);
             addJump(jePtr(X86::eax, ImmPtr(JSValuePtr::encode(jsNull()))), target + 2);            
 
@@ -812 +812 @@
             // Now handle the immediate cases - undefined & null
             isImmediate.link(this);
-            and32(Imm32(~JSImmediate::ExtendedTagBitUndefined), X86::eax);
+            andPtr(Imm32(~JSImmediate::ExtendedTagBitUndefined), X86::eax);
             addJump(jnePtr(X86::eax, ImmPtr(JSValuePtr::encode(jsNull()))), target + 2);            
 
@@ -1149 +1149 @@
             isImmediate.link(this);
 
-            and32(Imm32(~JSImmediate::ExtendedTagBitUndefined), X86::eax);
+            andPtr(Imm32(~JSImmediate::ExtendedTagBitUndefined), X86::eax);
             sete32(Imm32(JSImmediate::FullTagTypeNull), X86::eax);
 
@@ -1173 +1173 @@
             isImmediate.link(this);
 
-            and32(Imm32(~JSImmediate::ExtendedTagBitUndefined), X86::eax);
+            andPtr(Imm32(~JSImmediate::ExtendedTagBitUndefined), X86::eax);
             setne32(Imm32(JSImmediate::FullTagTypeNull), X86::eax);