Changeset 40608 in webkit for trunk/JavaScriptCore/runtime/Structure.cpp

Timestamp:

Feb 4, 2009, 12:55:28 AM (16 years ago)

Author:

[email protected]

Message:

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=23681
Worker tests crash in debug builds if run --singly

The crash happened because worker threads continued running while debug-only static objects
were already being destroyed on main thread.

• runtime/Structure.cpp: Create static debug-only sets in heap, so that they don't get destroyed.

• wtf/ThreadingPthreads.cpp: Changed assertions to conventional form.

File:

• trunk/JavaScriptCore/runtime/Structure.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/Structure.cpp

@@ -66 +66 @@
 
 #if ENABLE(JSC_MULTIPLE_THREADS)
-static Mutex ignoreSetMutex;
+static Mutex& ignoreSetMutex = *(new Mutex);
 #endif
 
 static bool shouldIgnoreLeaks;
-static HashSet<Structure*> ignoreSet;
+static HashSet<Structure*>& ignoreSet = *(new HashSet<Structure*>);
 #endif
 
 #if DUMP_STRUCTURE_ID_STATISTICS
-static HashSet<Structure*> liveStructureSet;
+static HashSet<Structure*>& liveStructureSet = *(new HashSet<Structure*>);
 #endif