Changeset 41083 in webkit for trunk/JavaScriptCore/runtime/JSImmediate.cpp

Timestamp:

Feb 19, 2009, 12:35:55 PM (16 years ago)

Author:

[email protected]

Message:

2009-02-18 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

Simplified .call and .apply in preparation for optimizing them. Also,
a little cleanup.

• runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall): No need to do any specific conversion on 'this' -- op_convert_this will do it if necessary.

• runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): Slightly relaxed the rules on toThisObject to allow for 'undefined', which can be passed through .call and .apply.

File:

• trunk/JavaScriptCore/runtime/JSImmediate.cpp (modified) (1 diff)

trunk/JavaScriptCore/runtime/JSImmediate.cpp

@@ -40 +40 @@
     if (isBoolean(v))
         return constructBooleanFromImmediateBoolean(exec, v);
-    if (v.isNull())
-        return exec->globalThisValue();
-    
-    JSNotAnObjectErrorStub* exception = createNotAnObjectErrorStub(exec, v.isNull());
-    exec->setException(exception);
-    return new (exec) JSNotAnObject(exec, exception);
+    ASSERT(v.isUndefinedOrNull());
+    return exec->globalThisValue();
 }