Changeset 41275 in webkit for trunk/JavaScriptCore/jit/JIT.cpp

Timestamp:

Feb 26, 2009, 5:09:43 PM (16 years ago)

Author:

[email protected]

Message:

2009-02-26 Gavin Barraclough <​[email protected]>

Reviewed by Oliver Hunt.

Integer Immediate representation need not be canonical in x86 JIT code.
On x86-64 we already have loosened the requirement that the int immediate
representation in canonical, we should bring x86 into line.

This patch is a minor (~0.5%) improvement on sunspider & v8-tests, and
should reduce memory footoprint (reduces JIT code size).

• jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileSlowCases):
• jit/JIT.h: (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber):
• jit/JITArithmetic.cpp: (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):

File:

• trunk/JavaScriptCore/jit/JIT.cpp (modified) (4 diffs)

trunk/JavaScriptCore/jit/JIT.cpp

@@ -236 +236 @@
     emitGetVirtualRegisters(src1, regT0, src2, regT1);
 
-#if USE(ALTERNATE_JSIMMEDIATE)
     // Jump to a slow case if either operand is a number, or if both are JSCell*s.
     move(regT0, regT2);
@@ -248 +247 @@
         set32(NotEqual, regT1, regT0, regT0);
     emitTagAsBoolImmediate(regT0);
-#else
-    bool negated = (type == OpNStrictEq);
-
-    // Check that both are immediates, if so check if they're equal
-    Jump firstNotImmediate = emitJumpIfJSCell(regT0);
-    Jump secondNotImmediate = emitJumpIfJSCell(regT1);
-    Jump bothWereImmediatesButNotEqual = branchPtr(NotEqual, regT1, regT0);
-
-    // They are equal - set the result to true. (Or false, if negated).
-    move(ImmPtr(JSValuePtr::encode(jsBoolean(!negated))), regT0);
-    Jump bothWereImmediatesAndEqual = jump();
-
-    // eax was not an immediate, we haven't yet checked edx.
-    // If edx is also a JSCell, or is 0, then jump to a slow case,
-    // otherwise these values are not equal.
-    firstNotImmediate.link(this);
-    emitJumpSlowCaseIfJSCell(regT1);
-    addSlowCase(branchPtr(Equal, regT1, ImmPtr(JSValuePtr::encode(js0()))));
-    Jump firstWasNotImmediate = jump();
-
-    // eax was an immediate, but edx wasn't.
-    // If eax is 0 jump to a slow case, otherwise these values are not equal.
-    secondNotImmediate.link(this);
-    addSlowCase(branchPtr(Equal, regT0, ImmPtr(JSValuePtr::encode(js0()))));
-
-    // We get here if the two values are different immediates, or one is 0 and the other is a JSCell.
-    // Vaelues are not equal, set the result to false.
-    bothWereImmediatesButNotEqual.link(this);
-    firstWasNotImmediate.link(this);
-    move(ImmPtr(JSValuePtr::encode(jsBoolean(negated))), regT0);
-    
-    bothWereImmediatesAndEqual.link(this);
-#endif
 
     emitPutVirtualRegister(dst);
@@ -1546 +1512 @@
             linkSlowCase(iter);
             linkSlowCase(iter);
-#if !USE(ALTERNATE_JSIMMEDIATE)
-            linkSlowCase(iter);
-#endif
             emitPutJITStubArg(regT0, 1);
             emitPutJITStubArg(regT1, 2);
@@ -1558 +1521 @@
             linkSlowCase(iter);
             linkSlowCase(iter);
-#if !USE(ALTERNATE_JSIMMEDIATE)
-            linkSlowCase(iter);
-#endif
             emitPutJITStubArg(regT0, 1);
             emitPutJITStubArg(regT1, 2);