Changeset 41277 in webkit for trunk/JavaScriptCore/jit/JITStubs.cpp

Timestamp:

Feb 26, 2009, 7:32:17 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2009-02-26 Gavin Barraclough <​[email protected]>

Reviewed by Geoff Garen.

Fix bug #23614. Switches on double precision values were incorrectly
truncating the scrutinee value. E.g.:

switch (1.1) { case 1: print("FAIL"); }

Was resulting in FAIL.

• interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
• jit/JITStubs.cpp: (JSC::JITStubs::cti_op_switch_imm):

LayoutTests:

2009-02-26 Gavin Barraclough <​[email protected]>

Rubber stamped by Geoff Garen.

Layout test for bug #23614.

• fast/js/resources/switch-behaviour.js:
• fast/js/switch-behaviour-expected.txt:

File:

• trunk/JavaScriptCore/jit/JITStubs.cpp (modified) (1 diff)

trunk/JavaScriptCore/jit/JITStubs.cpp

@@ -2026 +2026 @@
         return codeBlock->immediateSwitchJumpTable(tableIndex).ctiForValue(scrutinee.getInt32Fast()).addressForSwitch();
     else {
-        int32_t value;
-        if (scrutinee.numberToInt32(value))
-            return codeBlock->immediateSwitchJumpTable(tableIndex).ctiForValue(value).addressForSwitch();
+        double value;
+        int32_t intValue;
+        if (scrutinee.getNumber(value) && ((intValue = static_cast<int32_t>(value)) == value))
+            return codeBlock->immediateSwitchJumpTable(tableIndex).ctiForValue(intValue).addressForSwitch();
         else
             return codeBlock->immediateSwitchJumpTable(tableIndex).ctiDefault.addressForSwitch();