Changeset 41342 in webkit for trunk/JavaScriptCore/parser/Nodes.h

Timestamp:

Mar 1, 2009, 11:35:47 AM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2009-03-01 Horia Olaru <​[email protected]>

By looking in grammar.y there are only a few types of statement nodes
on which the debugger should stop.

Removed isBlock and isLoop virtual calls. No need to emit debug hooks in
the "statementListEmitCode" method as long as the necessary hooks can be
added in each "emitCode".

​https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

• parser/Nodes.cpp: (JSC::ConstStatementNode::emitBytecode): (JSC::statementListEmitCode): (JSC::EmptyStatementNode::emitBytecode): (JSC::ExprStatementNode::emitBytecode): (JSC::VarStatementNode::emitBytecode): (JSC::IfNode::emitBytecode): (JSC::IfElseNode::emitBytecode): (JSC::DoWhileNode::emitBytecode): (JSC::WhileNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ContinueNode::emitBytecode): (JSC::BreakNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::SwitchNode::emitBytecode): (JSC::LabelNode::emitBytecode): (JSC::ThrowNode::emitBytecode): (JSC::TryNode::emitBytecode):
• parser/Nodes.h:

WebCore:

2009-03-01 Horia Olaru <​[email protected]>

Adding manual debugger test cases for bug.

​https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

• manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
• manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
• manual-tests/inspector/debugger-step-on-for-statements.html: Added.
• manual-tests/inspector/debugger-step-on-while-statements.html: Added.
• manual-tests/inspector/resources/loop-statements.js: Added.

File:

• trunk/JavaScriptCore/parser/Nodes.h (modified) (6 diffs)

trunk/JavaScriptCore/parser/Nodes.h

@@ -195 +195 @@
         virtual bool isExprStatement() const JSC_FAST_CALL { return false; }
 
-        virtual bool isBlock() const JSC_FAST_CALL { return false; }
-        virtual bool isLoop() const JSC_FAST_CALL { return false; }
-
     private:
         int m_lastLine;
@@ -1709 +1706 @@
         StatementVector& children() { return m_children; }
 
-        virtual bool isBlock() const JSC_FAST_CALL { return true; }
-
     private:
         StatementVector m_children;
@@ -1822 +1817 @@
         virtual RegisterID* emitBytecode(BytecodeGenerator&, RegisterID* = 0) JSC_FAST_CALL;
 
-        virtual bool isLoop() const JSC_FAST_CALL { return true; }
-
     private:
         RefPtr<StatementNode> m_statement;
@@ -1842 +1835 @@
 
         virtual RegisterID* emitBytecode(BytecodeGenerator&, RegisterID* = 0) JSC_FAST_CALL;
-
-        virtual bool isLoop() const JSC_FAST_CALL { return true; }
 
     private:
@@ -1868 +1859 @@
         virtual RegisterID* emitBytecode(BytecodeGenerator&, RegisterID* = 0) JSC_FAST_CALL;
 
-        virtual bool isLoop() const JSC_FAST_CALL { return true; }
-
     private:
         RefPtr<ExpressionNode> m_expr1;
@@ -1887 +1876 @@
 
         virtual RegisterID* emitBytecode(BytecodeGenerator&, RegisterID* = 0) JSC_FAST_CALL;
-
-        virtual bool isLoop() const JSC_FAST_CALL { return true; }
 
     private: