Changeset 41605 in webkit for trunk/JavaScriptCore/wtf/ThreadingPthreads.cpp

Timestamp:

Mar 11, 2009, 6:26:55 PM (16 years ago)

Author:

Darin Adler

Message:

2009-03-11 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Give threads names on platforms with pthread_setname_np.

• wtf/Threading.cpp: (WTF::NewThreadContext::NewThreadContext): Initialize thread name. (WTF::threadEntryPoint): Call setThreadNameInternal. (WTF::createThread): Pass thread name.

• wtf/Threading.h: Added new comments, setThreadNameInternal.

• wtf/ThreadingGtk.cpp: (WTF::setThreadNameInternal): Added. Empty.
• wtf/ThreadingNone.cpp: (WTF::setThreadNameInternal): Added. Empty.
• wtf/ThreadingPthreads.cpp: (WTF::setThreadNameInternal): Call pthread_setname_np when available.
• wtf/ThreadingQt.cpp: (WTF::setThreadNameInternal): Added. Empty.
• wtf/ThreadingWin.cpp: (WTF::setThreadNameInternal): Added. Empty.

File:

• trunk/JavaScriptCore/wtf/ThreadingPthreads.cpp (modified) (5 diffs)

trunk/JavaScriptCore/wtf/ThreadingPthreads.cpp

@@ -1 +1 @@
 /*
- * Copyright (C) 2007 Apple Inc. All rights reserved.
+ * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Justin Haygood ([email protected])
  *
@@ -27 +27 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
 #include "config.h"
 #include "Threading.h"
-
-#include "StdLibExtras.h"
 
 #if USE(PTHREADS)
@@ -38 +37 @@
 #include "MainThread.h"
 #include "RandomNumberSeed.h"
-
+#include "StdLibExtras.h"
+#include "UnusedParam.h"
 #include <errno.h>
 #include <limits.h>
@@ -134 +134 @@
 {
     pthread_t threadHandle;
-    if (pthread_create(&threadHandle, NULL, entryPoint, data)) {
+    if (pthread_create(&threadHandle, 0, entryPoint, data)) {
         LOG_ERROR("Failed to create pthread at entry point %p with data %p", entryPoint, data);
         return 0;
@@ -140 +140 @@
 
     return establishIdentifierForPthreadHandle(threadHandle);
+}
+
+void setThreadNameInternal(const char* threadName)
+{
+#if PLATFORM(DARWIN) && !defined(BUILDING_ON_TIGER) && !defined(BUILDING_ON_LEOPARD)
+    pthread_setname_np(threadName);
+#else
+    UNUSED_PARAM(threadName);
+#endif
 }