Changeset 41846 in webkit for trunk/JavaScriptCore/API/tests/testapi.c

Timestamp:

Mar 19, 2009, 5:03:57 PM (16 years ago)

Author:

[email protected]

Message:

2009-03-19 Cameron Zwarich <​[email protected]>

Reviewed by Geoff Garen.

Bug 23771: REGRESSION (r36016): JSObjectHasProperty freezes on global class without kJSClassAttributeNoAutomaticPrototype
<​https://bugs.webkit.org/show_bug.cgi?id=23771>
<rdar://problem/6561016>

• API/tests/testapi.c: (main): Add a test for this bug.
• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::resetPrototype): Don't set the prototype of the last object in the prototype chain to the object prototype when the object prototype is already the last object in the prototype chain.

File:

• trunk/JavaScriptCore/API/tests/testapi.c (modified) (1 diff)

trunk/JavaScriptCore/API/tests/testapi.c

@@ -992 +992 @@
     JSClassRelease(globalObjectClass);
 
+    // Test for an infinite prototype chain that used to be created. This test
+    // passes if the call to JSObjectHasProperty() does not hang.
+
+    JSClassDefinition prototypeLoopClassDefinition = kJSClassDefinitionEmpty;
+    prototypeLoopClassDefinition.staticFunctions = globalObject_staticFunctions;
+    JSClassRef prototypeLoopClass = JSClassCreate(&prototypeLoopClassDefinition);
+    JSGlobalContextRef prototypeLoopContext = JSGlobalContextCreateInGroup(NULL, prototypeLoopClass);
+
+    JSStringRef nameProperty = JSStringCreateWithUTF8CString("name");
+    JSObjectHasProperty(prototypeLoopContext, JSContextGetGlobalObject(prototypeLoopContext), nameProperty);
+
+    JSGlobalContextRelease(prototypeLoopContext);
+    JSClassRelease(prototypeLoopClass);
+
+    printf("PASS: Infinite prototype chain does not occur.\n");
+
     printf("PASS: Program exited normally.\n");
     return 0;