Changeset 41852 in webkit for trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h

Timestamp:

Mar 19, 2009, 9:28:35 PM (16 years ago)

Author:

[email protected]

Message:

JavaScriptCore:

2009-03-19 Geoffrey Garen <​[email protected]>

Reviewed by Cameron Zwarich and Oliver Hunt.

Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
fast/workers/use-machine-stack.html (22531)

Dialed down the re-entry allowance to 64 (from 128).

On a 512K stack, this leaves about 64K for other code on the stack while
JavaScript is running. Not perfect, but it solves our crash on PPC.

Different platforms may want to dial this down even more.

Also, substantially shrunk BytecodeGenerator. Since we allocate one on
the stack in order to throw a stack overflow exception -- well, let's
just say the old code had an appreciation for irony.

SunSpider reports no change.

• bytecompiler/BytecodeGenerator.h:
• interpreter/Interpreter.h: (JSC::):

LayoutTests:

2009-03-19 Geoffrey Garen <​[email protected]>

Reviewed by Cameron Zwarich and Oliver Hunt.

Re-enabled this test, since it no longer crashes when JavaScriptCore is
compiled in non-JIT mode.

• fast/workers/use-machine-stack.html: Copied from fast/workers/use-machine-stack.html-disabled.
• fast/workers/use-machine-stack.html-disabled: Removed.

File:

• trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h (modified) (1 diff)

trunk/JavaScriptCore/bytecompiler/BytecodeGenerator.h

@@ -439 +439 @@
         RegisterID m_argumentsRegister;
         int m_activationRegisterIndex;
-        SegmentedVector<RegisterID, 512> m_calleeRegisters;
-        SegmentedVector<RegisterID, 512> m_parameters;
-        SegmentedVector<RegisterID, 512> m_globals;
-        SegmentedVector<LabelScope, 256> m_labelScopes;
-        SegmentedVector<Label, 256> m_labels;
+        SegmentedVector<RegisterID, 32> m_calleeRegisters;
+        SegmentedVector<RegisterID, 32> m_parameters;
+        SegmentedVector<RegisterID, 32> m_globals;
+        SegmentedVector<LabelScope, 8> m_labelScopes;
+        SegmentedVector<Label, 32> m_labels;
         RefPtr<RegisterID> m_lastConstant;
         int m_finallyDepth;