Changeset 41872 in webkit for trunk/JavaScriptCore/jit/ExecutableAllocator.h

Timestamp:

Mar 20, 2009, 3:56:27 PM (16 years ago)

Author:

[email protected]

Message:

2009-03-20 Geoffrey Garen <​[email protected]>

Reviewed by Oliver Hunt.

A little cleanup in the RegisterFile code.

Moved large inline functions out of the class declaration, to make it
more readable.

Switched over to using the roundUpAllocationSize function to avoid
duplicate code and subtle bugs.

Renamed m_maxCommitted to m_commitEnd, to match m_end.

Renamed allocationSize to commitSize because it's the chunk size for
committing memory, not allocating memory.

SunSpider reports no change.

• interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): (JSC::RegisterFile::shrink): (JSC::RegisterFile::grow):
• jit/ExecutableAllocator.h: (JSC::roundUpAllocationSize):

File:

• trunk/JavaScriptCore/jit/ExecutableAllocator.h (modified) (2 diffs)

trunk/JavaScriptCore/jit/ExecutableAllocator.h

@@ -40 +40 @@
 
 namespace JSC {
+
+inline size_t roundUpAllocationSize(size_t request, size_t granularity)
+{
+    if ((std::numeric_limits<size_t>::max() - granularity) <= request)
+        CRASH(); // Allocation is too large
+    
+    // Round up to next page boundary
+    size_t size = request + (granularity - 1);
+    size = size & ~(granularity - 1);
+    ASSERT(size >= request);
+    return size;
+}
 
 class ExecutablePool : public RefCounted<ExecutablePool> {
@@ -86 +98 @@
     static Allocation systemAlloc(size_t n);
     static void systemRelease(const Allocation& alloc);
-
-    inline size_t roundUpAllocationSize(size_t request, size_t granularity)
-    {
-        if ((std::numeric_limits<size_t>::max() - granularity) <= request)
-            CRASH(); // Allocation is too large
-        
-        // Round up to next page boundary
-        size_t size = request + (granularity - 1);
-        size = size & ~(granularity - 1);
-        ASSERT(size >= request);
-        return size;
-    }
 
     ExecutablePool(size_t n);