Changeset 42065 in webkit for trunk/JavaScriptCore/bytecode/CodeBlock.cpp

Timestamp:

Mar 27, 2009, 8:50:39 PM (16 years ago)

Author:

[email protected]

Message:

Improve performance of Function.prototype.call
<​https://bugs.webkit.org/show_bug.cgi?id=24907>

Reviewed by Gavin Barraclough

Optimistically assume that expression.call(..) is going to be a call to
Function.prototype.call, and handle it specially to attempt to reduce the
degree of VM reentrancy.

When everything goes right this removes the vm reentry improving .call()
by around a factor of 10.

File:

• trunk/JavaScriptCore/bytecode/CodeBlock.cpp (modified) (1 diff)

trunk/JavaScriptCore/bytecode/CodeBlock.cpp

@@ -889 +889 @@
             break;
         }
-        case op_jnless: {
+        case op_jneq_ptr: {
             int r0 = (++it)->u.operand;
             int r1 = (++it)->u.operand;
             int offset = (++it)->u.operand;
-            printf("[%4d] jnless\t\t %s, %s, %d(->%d)\n", location, registerName(r0).c_str(), registerName(r1).c_str(), offset, locationForOffset(begin, it, offset));
+            printf("[%4d] jneq_ptr\t\t %s, %s, %d(->%d)\n", location, registerName(r0).c_str(), registerName(r1).c_str(), offset, locationForOffset(begin, it, offset));
+            break;
+        }
+        case op_jnless: {
+            int r0 = (++it)->u.operand;
+            JSValuePtr function = JSValuePtr((++it)->u.jsCell);
+            int offset = (++it)->u.operand;
+            printf("[%4d] jnless\t\t %s, %s, %d(->%d)\n", location, registerName(r0).c_str(), valueToSourceString(exec, function).ascii(), offset, locationForOffset(begin, it, offset));
             break;
         }